Skip to content

Skip flaky tests TestFileWatcher and TestGroup_Go#41223

Merged
belimawr merged 2 commits intoelastic:mainfrom
belimawr:skip-flaky-tests
Oct 14, 2024
Merged

Skip flaky tests TestFileWatcher and TestGroup_Go#41223
belimawr merged 2 commits intoelastic:mainfrom
belimawr:skip-flaky-tests

Conversation

@belimawr
Copy link
Copy Markdown
Contributor

@belimawr belimawr commented Oct 14, 2024

Proposed commit message

This PR skips two flaky tests from the Filestream input, the tests are:

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Disruptive User Impact
## Author's Checklist
## How to test this PR locally

Related issues

## Use cases
## Screenshots
## Logs

@belimawr belimawr added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 14, 2024
@belimawr belimawr requested a review from a team as a code owner October 14, 2024 14:43
@belimawr belimawr requested review from AndersonQ and rdner October 14, 2024 14:43
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 14, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 14, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 14, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @belimawr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 14, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 14, 2024
rdner
rdner reviewed Oct 14, 2024
View reviewed changes
@belimawr belimawr enabled auto-merge (squash) October 14, 2024 15:53
@belimawr
Copy link
Copy Markdown
Contributor Author

belimawr commented Oct 14, 2024

I've enabled auto merge.

@belimawr belimawr merged commit e9617a7 into elastic:main Oct 14, 2024
mergify bot pushed a commit that referenced this pull request Oct 14, 2024
@belimawr @rdner @mergify
Skip flaky tests TestFileWatcher and TestGroup_Go (#41223)
cfde150 
---------

Co-authored-by: Denis <denis@rdner.de>
(cherry picked from commit e9617a7)
@mergify mergify bot mentioned this pull request Oct 14, 2024
Merged
6 tasks
@mauri870 mauri870 mentioned this pull request Oct 14, 2024
Merged
rdner pushed a commit that referenced this pull request Oct 14, 2024
@mergify @belimawr
Skip flaky tests TestFileWatcher and TestGroup_Go (#41223) (#41228)
be27d76 
---------

Co-authored-by: Denis <denis@rdner.de>
(cherry picked from commit e9617a7)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
@mergify mergify bot mentioned this pull request Oct 15, 2024
Merged
@belimawr belimawr deleted the skip-flaky-tests branch December 19, 2024 13:56
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdner rdner rdner approved these changes

@mauri870 mauri870 mauri870 approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@belimawr belimawr

Labels

backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@belimawr @elasticmachine @rdner @mauri870