Add input identification support to the shipper output#31942
Merged
rdner merged 3 commits intoelastic:mainfrom Jun 16, 2022
Merged
Add input identification support to the shipper output#31942rdner merged 3 commits intoelastic:mainfrom
rdner merged 3 commits intoelastic:mainfrom
Conversation
So, we can send the real events to the shipper.
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
cmacknz
reviewed
Jun 15, 2022
| return structpb.NewStructValue(s), nil | ||
| } | ||
|
|
||
| func toShipperEvent(e publisher.Event) (*sc.Event, error) { |
Member
There was a problem hiding this comment.
Not for this review, but it would be interesting to benchmark the conversions to the shipper data types to see what the overhead is. This will be new overhead added to every event sent from every beat.
cmacknz
approved these changes
Jun 15, 2022
Member
Author
|
/test |
Member
Author
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
So, we can send the real events to the shipper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This implements the Input/Stream Identification in the new Shipper Pipeline proposal, so we can start sending events to the shipper server.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues