Skip to content

Add input identification support to the shipper output#31942

Merged
rdner merged 3 commits intoelastic:mainfrom
rdner:shipper-input-id
Jun 16, 2022
Merged

Add input identification support to the shipper output#31942
rdner merged 3 commits intoelastic:mainfrom
rdner:shipper-input-id

Conversation

@rdner
Copy link
Copy Markdown
Member

@rdner rdner commented Jun 15, 2022

What does this PR do?

This implements the Input/Stream Identification in the new Shipper Pipeline proposal, so we can start sending events to the shipper server.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

So, we can send the real events to the shipper.
@rdner rdner added enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jun 15, 2022
@rdner rdner requested a review from cmacknz June 15, 2022 12:05
@rdner rdner requested a review from a team as a code owner June 15, 2022 12:05
@rdner rdner self-assigned this Jun 15, 2022
@rdner rdner requested review from fearful-symmetry and removed request for a team June 15, 2022 12:05
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 15, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-16T09:17:17.348+0000

  • Duration: 86 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 22268
Skipped 1937
Total 24205

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@rdner rdner added the v8.4.0 label Jun 15, 2022
@cmacknz cmacknz requested a review from faec June 15, 2022 12:49
return structpb.NewStructValue(s), nil
}

func toShipperEvent(e publisher.Event) (*sc.Event, error) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this review, but it would be interesting to benchmark the conversions to the shipper data types to see what the overhead is. This will be new overhead added to every event sent from every beat.

@rdner
Copy link
Copy Markdown
Member Author

rdner commented Jun 15, 2022

/test

@rdner
Copy link
Copy Markdown
Member Author

rdner commented Jun 16, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 16, 2022

update

✅ Branch has been successfully updated

@rdner rdner merged commit 125c57b into elastic:main Jun 16, 2022
@rdner rdner deleted the shipper-input-id branch June 16, 2022 11:31
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
So, we can send the real events to the shipper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for input and data stream identification when sending events

3 participants