This repository was archived by the owner on Sep 21, 2023. It is now read-only.
Update API protocol#56
Merged
rdner merged 5 commits intoelastic:mainfrom Jun 16, 2022
rdner:update-api-protocol
Merged
Conversation
This is a breaking change for the protocol! * Added `Source` for some data the shipper server requires. * Removed `Input` from `Event` * Removed `id` from `DataStream` * Refreshed the field ordering
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
2 tasks
cmacknz
reviewed
Jun 15, 2022
cmacknz
reviewed
Jun 15, 2022
cmacknz
reviewed
Jun 15, 2022
cmacknz
reviewed
Jun 15, 2022
cmacknz
reviewed
Jun 15, 2022
cmacknz
reviewed
Jun 15, 2022
Member
|
For some context, I found the two PRs adding input ID and stream ID uniqueness on the fleet side if you want to see how these fields are generated: |
This reverts commit be67fb1.
cmacknz
approved these changes
Jun 15, 2022
Member
cmacknz
left a comment
There was a problem hiding this comment.
Approving so this doesn't sit for a day waiting for minor comment updates :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change for the protocol!
Sourcefor some data the shipper server requires.InputfromEventidfromDataStream