Heartbeat: fix browser metrics and trace mappings#30258
Merged
vigneshshanmugam merged 3 commits intoelastic:mainfrom Feb 16, 2022
Merged
Heartbeat: fix browser metrics and trace mappings#30258vigneshshanmugam merged 3 commits intoelastic:mainfrom
vigneshshanmugam merged 3 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/uptime (Team:Uptime) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
lucasfcosta
approved these changes
Feb 15, 2022
Contributor
lucasfcosta
left a comment
There was a problem hiding this comment.
I have E2E tested this and compared these changes to the mappings for the synthetics integration. It LGTM.
My E2E test consisted of:
- Creating a Heartbeat config file with browser monitors
- Checking out this branch and running
mage build - Running the built Heartbeat against my local ES
- Checking the documents sent on the Kibana Dev Console
GET /.ds-heartbeat-8.2.0-2022.02.15-000001/_search { "size": 50, "query": { "match": { "event.type": "step/metrics" } } } - Checking the mappings themselves in the index management screen
- Making sure the monitors themselves work fine (including the waterfall chart)
I'd appreciate it if @dominiqueclarke could just confirm these look OK on her side too, but no need to E2E test I'd say.
mergify bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
* Heartbeat: fix browser metrics and trace mappings * update fields (cherry picked from commit f535d19) # Conflicts: # heartbeat/include/fields.go # x-pack/heartbeat/include/fields.go
mergify bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
* Heartbeat: fix browser metrics and trace mappings * update fields (cherry picked from commit f535d19)
mergify bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
* Heartbeat: fix browser metrics and trace mappings * update fields (cherry picked from commit f535d19)
vigneshshanmugam
added a commit
that referenced
this pull request
Feb 16, 2022
vigneshshanmugam
added a commit
that referenced
this pull request
Feb 16, 2022
vigneshshanmugam
added a commit
that referenced
this pull request
Feb 16, 2022
…ings (#30416) * Heartbeat: fix browser metrics and trace mappings (#30258) * Heartbeat: fix browser metrics and trace mappings * update fields (cherry picked from commit f535d19) # Conflicts: # heartbeat/include/fields.go # x-pack/heartbeat/include/fields.go * update fields Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
v1v
added a commit
to v1v/beats
that referenced
this pull request
Feb 21, 2022
…into feature/use-with-kind-k8s-env * 'feature/use-with-kind-k8s-env' of github.com:v1v/beats: (52 commits) ci: home is declared within withBeatsEnv ci: use withKindEnv step ci: use getBranchesFromAliases and support next-patch-8 (elastic#30400) Update fields.yml (elastic#29609) Heartbeat: fix browser metrics and trace mappings (elastic#30258) Apply light edits to 8.0 changelog (elastic#30351) packetbeat/beater: make sure Npcap installation runs before interfaces are needed (elastic#30396) Add a ring-buffer reporter to libbeat (elastic#28750) Osquerybeat: Add install verification for osquerybeat (elastic#30388) update windows matrix support (elastic#30373) Refactor of metricbeat process-gathering metrics and system/process (elastic#30076) adjust next changelog wording (elastic#30371) [Metricbeat] azure: move event report into loop validDim loop (elastic#29945) fix: report GitHub Check before the cache (elastic#30372) Add support for non-unique keys in Kafka output headers (elastic#30369) ci: 6 major branch reached EOL (elastic#30357) reduce Elastic Agent shut down time by stopping processes concurrently (elastic#29650) [Filebeat] Add message to register encode/decode debug logs (elastic#30271) [libbeat] kafka message header support (elastic#29940) Heartbeat: set duration to zero for syntax errors (elastic#30227) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
browser.experienceandbrowser.relative_traceto the root HB mapping fields.