Skip to content

Heartbeat: set duration to zero for syntax errors#30227

Merged
vigneshshanmugam merged 2 commits intoelastic:mainfrom
vigneshshanmugam:fix-monitor-duration
Feb 11, 2022
Merged

Heartbeat: set duration to zero for syntax errors#30227
vigneshshanmugam merged 2 commits intoelastic:mainfrom
vigneshshanmugam:fix-monitor-duration

Conversation

@vigneshshanmugam
Copy link
Copy Markdown
Member

@vigneshshanmugam vigneshshanmugam commented Feb 4, 2022

  • When there are syntax errors in the monitor script, the journey/start never fires as the Synthetics runner cannot register the journeys and node runs to completion with exit status 1.
  • In these cases, determining the duration between start/end event would be tricky and since the journeys never run in the first place, Its good to set the duration to 0 instead of setting false positive values.
  • Added extensive test cases for summary event creation for various scenarios
heartbeat.run_once: true
# Configure monitors inline
heartbeat.monitors:
  - type: browser
    id: my-monitor
    name: My Monitor
    source:
      inline:
        script: step("load homepage", async () => {);
    schedule: "@every 1m"

output.console: ~
``

@vigneshshanmugam vigneshshanmugam added Team:obs-ds-hosted-services Label for the Observability Hosted Services team backport-v8.0.0 Automated backport with mergify v8.1.0 backport-v8.1.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Feb 4, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 4, 2022

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 4, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 4, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-11T19:20:39.842+0000

  • Duration: 48 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 125
Skipped 0
Total 125

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

andrewvc
andrewvc approved these changes Feb 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (also verified the behavior works well on kibana)

@paulb-elastic
Copy link
Copy Markdown
Contributor

paulb-elastic commented Feb 11, 2022

Discussed in Tech Sync to consider having this as null rather than 0 (with a view on if that's supported in the UI)
/cc @vigneshshanmugam

andrewvc
andrewvc approved these changes Feb 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominiqueclarke dominiqueclarke mentioned this pull request Feb 11, 2022
Merged
@vigneshshanmugam vigneshshanmugam merged commit 06c810c into elastic:main Feb 11, 2022
mergify bot pushed a commit that referenced this pull request Feb 11, 2022
@vigneshshanmugam
Heartbeat: set duration to zero for syntax errors (#30227)
c5c8a95 
* Heartbeat: set duration to 0 for syntax errors

* set duration to null

(cherry picked from commit 06c810c)
@mergify mergify bot mentioned this pull request Feb 11, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 11, 2022
@vigneshshanmugam
Heartbeat: set duration to zero for syntax errors (#30227)
4ca36a1 
* Heartbeat: set duration to 0 for syntax errors

* set duration to null

(cherry picked from commit 06c810c)
@mergify mergify bot mentioned this pull request Feb 11, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 11, 2022
@vigneshshanmugam
Heartbeat: set duration to zero for syntax errors (#30227)
71595fb 
* Heartbeat: set duration to 0 for syntax errors

* set duration to null

(cherry picked from commit 06c810c)
@mergify mergify bot mentioned this pull request Feb 11, 2022
Merged
vigneshshanmugam added a commit that referenced this pull request Feb 11, 2022
@mergify @vigneshshanmugam
Heartbeat: set duration to zero for syntax errors (#30227) (#30366)
367b018 
* Heartbeat: set duration to 0 for syntax errors

* set duration to null

(cherry picked from commit 06c810c)

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
vigneshshanmugam added a commit that referenced this pull request Feb 11, 2022
@mergify @vigneshshanmugam
Heartbeat: set duration to zero for syntax errors (#30227) (#30365)
cd57bd4 
* Heartbeat: set duration to 0 for syntax errors

* set duration to null

(cherry picked from commit 06c810c)

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
vigneshshanmugam added a commit that referenced this pull request Feb 11, 2022
@mergify @vigneshshanmugam
Heartbeat: set duration to zero for syntax errors (#30227) (#30364)
a659032 
* Heartbeat: set duration to 0 for syntax errors

* set duration to null

(cherry picked from commit 06c810c)

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
v1v added a commit to v1v/beats that referenced this pull request Feb 21, 2022
@v1v
Merge branch 'feature/use-with-kind-k8s-env' of github.com:v1v/beats …
c20f180 
…into feature/use-with-kind-k8s-env

* 'feature/use-with-kind-k8s-env' of github.com:v1v/beats: (52 commits)
  ci: home is declared within withBeatsEnv
  ci: use withKindEnv step
  ci: use getBranchesFromAliases and support next-patch-8 (elastic#30400)
  Update fields.yml (elastic#29609)
  Heartbeat: fix browser metrics and trace mappings (elastic#30258)
  Apply light edits to 8.0 changelog (elastic#30351)
  packetbeat/beater: make sure Npcap installation runs before interfaces are needed (elastic#30396)
  Add a ring-buffer reporter to libbeat (elastic#28750)
  Osquerybeat: Add install verification for osquerybeat (elastic#30388)
  update windows matrix support (elastic#30373)
  Refactor of metricbeat process-gathering metrics and system/process (elastic#30076)
  adjust next changelog wording (elastic#30371)
  [Metricbeat] azure: move event report into loop validDim loop (elastic#29945)
  fix: report GitHub Check before the cache (elastic#30372)
  Add support for non-unique keys in Kafka output headers (elastic#30369)
  ci: 6 major branch reached EOL (elastic#30357)
  reduce Elastic Agent shut down time by stopping processes concurrently (elastic#29650)
  [Filebeat] Add message to register encode/decode debug logs (elastic#30271)
  [libbeat] kafka message header support (elastic#29940)
  Heartbeat: set duration to zero for syntax errors (elastic#30227)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees

@vigneshshanmugam vigneshshanmugam

Labels

backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vigneshshanmugam @elasticmachine @paulb-elastic @andrewvc