Correctly fixe how selected packages are defined by ph · Pull Request #30039 · elastic/beats

ph · 2022-01-26T21:18:11Z

Fixed creating an empty array way breaking check down the stack.

See

beats/dev-tools/mage/pkg.go

Line 121 in 6b41742

if SelectedPackageTypes != nil {

What does this PR do?

Why is it important?

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

[ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Fixed creating an empty array way breaking check down the stack.o See https://github.com/elastic/beats/blob/6b417428d30971c75469651419cf39874189f268/dev-tools/mage/pkg.go#L121

elasticmachine · 2022-01-26T21:18:14Z

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

mergify · 2022-01-26T21:18:27Z

This pull request does not have a backport label. Could you fix it @ph? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

ph · 2022-01-26T21:20:48Z

/package

aleksmaus

Thank you! 👍

elasticmachine · 2022-01-26T23:19:11Z

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-01-26T21:18:25.975+0000
Duration: 120 min 16 sec
Commit: ae85071

Test stats 🧪

Test	Results
Failed	1
Passed	47950
Skipped	4284
Total	52235

Test errors

Expand to view the tests failures

`Extended / filebeat-windows-8-windows-8 / test_file_no_permission – filebeat.tests.system.test_crawler.Test`

Expand to view the error details

 PermissionError: [WinError 5] Access is denied: 'C:\\Users\\jenkins\\workspace\\PR-30039-1-6124aac1-7b2c-4f5a-9e2a-a14ba6fb6be1\\src\\github.com\\elastic\\beats\\filebeat\\build\\system-tests\\run\\test_crawler.Test.test_file_no_permission\\log\\test.log'

Expand to view the stacktrace

 ..\libbeat\tests\system\beat\beat.py:334: in setUp
    shutil.rmtree(self.working_dir)
C:\Python38\lib\shutil.py:737: in rmtree
    return _rmtree_unsafe(path, onerror)
C:\Python38\lib\shutil.py:610: in _rmtree_unsafe
    _rmtree_unsafe(fullname, onerror)
C:\Python38\lib\shutil.py:615: in _rmtree_unsafe
    onerror(os.unlink, fullname, sys.exc_info())
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

path = 'C:\\Users\\jenkins\\workspace\\PR-30039-1-6124aac1-7b2c-4f5a-9e2a-a14ba6fb6be1\\src\\github.com\\elastic\\beats\\filebeat\\build\\system-tests\\run\\test_crawler.Test.test_file_no_permission\\log'
onerror = <function rmtree.<locals>.onerror at 0x00000036517BBD30>

    def _rmtree_unsafe(path, onerror):
        try:
            with os.scandir(path) as scandir_it:
                entries = list(scandir_it)
        except OSError:
            onerror(os.scandir, path, sys.exc_info())
            entries = []
        for entry in entries:
            fullname = entry.path
            if _rmtree_isdir(entry):
                try:
                    if entry.is_symlink():
                        # This can only happen if someone replaces
                        # a directory with a symlink after the call to
                        # os.scandir or entry.is_dir above.
                        raise OSError("Cannot call rmtree on a symbolic link")
                except OSError:
                    onerror(os.path.islink, fullname, sys.exc_info())
                    continue
                _rmtree_unsafe(fullname, onerror)
            else:
                try:
>                   os.unlink(fullname)
E                   PermissionError: [WinError 5] Access is denied: 'C:\\Users\\jenkins\\workspace\\PR-30039-1-6124aac1-7b2c-4f5a-9e2a-a14ba6fb6be1\\src\\github.com\\elastic\\beats\\filebeat\\build\\system-tests\\run\\test_crawler.Test.test_file_no_permission\\log\\test.log'

C:\Python38\lib\shutil.py:613: PermissionError

Steps errors

Expand to view the steps failures

`Sleep`

Took 0 min 5 sec . View more details here
Description: 5

`filebeat-windows-8-windows-8 - mage build unitTest`

Took 6 min 52 sec . View more details here
Description: mage build unitTest

`filebeat-windows-8-windows-8 - mage build unitTest`

Took 4 min 16 sec . View more details here
Description: mage build unitTest

`filebeat-windows-8-windows-8 - mage build unitTest`

Took 4 min 20 sec . View more details here
Description: mage build unitTest

`gsutil -m -q cp -a public-read test-build-artifacts-filebeat-windows-8-windows-8-tgz gs://beats-ci-t`

Took 0 min 10 sec . View more details here
Description: @echo off gsutil -m -q cp -a public-read test-build-artifacts-filebeat-windows-8-windows-8-tgz gs://beats-ci-temp/Beats/beats/PR-30039-1

`Error signal`

Took 0 min 0 sec . View more details here
Description: Error 'hudson.AbortException: script returned exit code 1'

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

Name: Extended / filebeat-windows-8-windows-8 / test_file_no_permission – filebeat.tests.system.test_crawler.Test

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…k-version-after-8-0-creation * upstream/master: (69 commits) Update stale config following (elastic#30082) Make include_matches backwards compatible with 7.x config (elastic#30032) [Filebeat] Update handling of elasticsearch server logs (elastic#30018) Remove SSL3 support from libbeat and its documentation. (elastic#30071) Revert "Packaging: rename arm64 suffix to aarch64 in the tar.gz artifacts ONLY (elastic#28813)" (elastic#30083) [libbeat] Add script processor to all beats (elastic#29752) Add fonts to support more different types of characters for multiple languages (elastic#29861) libbeat/reader: Fix messge conversion to beat.Event (elastic#30057) probot[stale]: ignore issues with the tag flaky-test (elastic#30065) [DOCS] Add redirect for GSuite module (elastic#30034) [Automation] Update elastic stack version to 8.1.0-aa69d697 for testing (elastic#30012) Remove msitools install for windows build, using the latest docker image with msitools preinstalled (elastic#30040) filebeat/generator/fields: fix dropped error (elastic#29943) Include the error message with auditd module events (elastic#30009) [Metricbeat] gcp: add firestore metricset (elastic#29918) probot: update stale dates (elastic#29997) Metricbeat enterprise search module: add xpack.enabled support (elastic#29871) x-pack/packetbeat: install Npcap at start-up when required (elastic#29112) [Filebeat] Fix panic in decode_cef when recovering from invalid data (elastic#30038) Correctly fixe how selected packages are defined (elastic#30039) ...

Correctly fixed how selected packages are defined

ae85071

Fixed creating an empty array way breaking check down the stack.o See https://github.com/elastic/beats/blob/6b417428d30971c75469651419cf39874189f268/dev-tools/mage/pkg.go#L121

ph added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jan 26, 2022

ph requested a review from aleksmaus January 26, 2022 21:18

ph self-assigned this Jan 26, 2022

ph requested a review from a team as a code owner January 26, 2022 21:18

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 26, 2022

mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 26, 2022

ph changed the title ~~Correctly fixed how selected packages are defined~~ Correctly fixe how selected packages are defined Jan 26, 2022

aleksmaus approved these changes Jan 26, 2022

View reviewed changes

ph merged commit d84d342 into elastic:master Jan 26, 2022

ph deleted the fix/hey-build-system branch January 26, 2022 21:32

ph mentioned this pull request Jan 27, 2022

Revert changes in the artifact build from #29890 #30007

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correctly fixe how selected packages are defined#30039

Correctly fixe how selected packages are defined#30039
ph merged 1 commit intoelastic:masterfrom
ph:fix/hey-build-system

ph commented Jan 26, 2022 •

edited

Loading

Uh oh!

elasticmachine commented Jan 26, 2022

Uh oh!

mergify bot commented Jan 26, 2022

Uh oh!

ph commented Jan 26, 2022

Uh oh!

aleksmaus left a comment

Uh oh!

elasticmachine commented Jan 26, 2022

Build stats

Test stats 🧪

`Extended / filebeat-windows-8-windows-8 / test_file_no_permission – filebeat.tests.system.test_crawler.Test`

`Sleep`

`filebeat-windows-8-windows-8 - mage build unitTest`

`filebeat-windows-8-windows-8 - mage build unitTest`

`filebeat-windows-8-windows-8 - mage build unitTest`

`gsutil -m -q cp -a public-read test-build-artifacts-filebeat-windows-8-windows-8-tgz gs://beats-ci-t`

`Error signal`

Genuine test errors

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ph commented Jan 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Uh oh!

elasticmachine commented Jan 26, 2022

Uh oh!

mergify bot commented Jan 26, 2022

Uh oh!

ph commented Jan 26, 2022

Uh oh!

aleksmaus left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jan 26, 2022

💔 Tests Failed

Build stats

Test stats 🧪

Test errors

Extended / filebeat-windows-8-windows-8 / test_file_no_permission – filebeat.tests.system.test_crawler.Test

Steps errors

Sleep

filebeat-windows-8-windows-8 - mage build unitTest

filebeat-windows-8-windows-8 - mage build unitTest

filebeat-windows-8-windows-8 - mage build unitTest

gsutil -m -q cp -a public-read test-build-artifacts-filebeat-windows-8-windows-8-tgz gs://beats-ci-t

Error signal

🐛 Flaky test report

Genuine test errors

🤖 GitHub comments

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ph commented Jan 26, 2022 •

edited

Loading

`Extended / filebeat-windows-8-windows-8 / test_file_no_permission – filebeat.tests.system.test_crawler.Test`

`Sleep`

`filebeat-windows-8-windows-8 - mage build unitTest`

`filebeat-windows-8-windows-8 - mage build unitTest`

`filebeat-windows-8-windows-8 - mage build unitTest`

`gsutil -m -q cp -a public-read test-build-artifacts-filebeat-windows-8-windows-8-tgz gs://beats-ci-t`

`Error signal`