Skip to content

filebeat/generator/fields: fix dropped error#29943

Merged
cmacknz merged 1 commit intoelastic:masterfrom
alrs:generator-fields-err
Jan 27, 2022
Merged

filebeat/generator/fields: fix dropped error#29943
cmacknz merged 1 commit intoelastic:masterfrom
alrs:generator-fields-err

Conversation

@alrs
Copy link
Copy Markdown
Contributor

@alrs alrs commented Jan 21, 2022

  • bug

What does this PR do?

Picks up an err variable that was being dropped in filebeat/generator/fields.

Why is it important?

Dropped errors create inexplicable hard-to-find bugs.

Checklist

  • [ x ] My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 21, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 21, 2022

This pull request does not have a backport label. Could you fix it @alrs? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 21, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 21, 2022 •
edited by jenkins-beats-ci bot
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-26T18:49:50.160+0000

  • Duration: 21 min 24 sec

  • Commit: b028538

Steps errors 4

Expand to view the steps failures

gsutil -m -q cp -a public-read filebeat/build/distributions/**/* gs://beats-ci-artifacts/pull-reques
  • Took 0 min 2 sec . View more details here
  • Description: gsutil -m -q cp -a public-read filebeat/build/distributions/**/* gs://beats-ci-artifacts/pull-requests/pr-29943/filebeat
gsutil -m -q cp -a public-read filebeat/build/distributions/**/* gs://beats-ci-artifacts/pull-reques
  • Took 0 min 2 sec . View more details here
  • Description: gsutil -m -q cp -a public-read filebeat/build/distributions/**/* gs://beats-ci-artifacts/pull-requests/pr-29943/filebeat
gsutil -m -q cp -a public-read filebeat/build/distributions/**/* gs://beats-ci-artifacts/pull-reques
  • Took 0 min 2 sec . View more details here
  • Description: gsutil -m -q cp -a public-read filebeat/build/distributions/**/* gs://beats-ci-artifacts/pull-requests/pr-29943/filebeat
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 1'

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mtojek mtojek added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jan 24, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 24, 2022

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 24, 2022
@jlind23 jlind23 added bug Filebeat Filebeat labels Jan 24, 2022
@cmacknz cmacknz self-assigned this Jan 25, 2022
@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Jan 25, 2022

/test

cmacknz
cmacknz requested changes Jan 26, 2022
View reviewed changes
@alrs alrs force-pushed the generator-fields-err branch from 4a0deb2 to b028538 Compare January 26, 2022 15:54
@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Jan 26, 2022

/test

@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Jan 26, 2022

/test filebeat-packaging-linux

@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Jan 26, 2022

/test

@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Jan 27, 2022

The CI failure is from an unrelated change on master, merging.

@cmacknz cmacknz merged commit 206de56 into elastic:master Jan 27, 2022
v1v added a commit to v1v/beats that referenced this pull request Jan 31, 2022
@v1v
Merge remote-tracking branch 'upstream/master' into feature/bump-stac…
0ca8d43 
…k-version-after-8-0-creation

* upstream/master: (69 commits)
  Update stale config following (elastic#30082)
  Make include_matches backwards compatible with 7.x config (elastic#30032)
  [Filebeat] Update handling of elasticsearch server logs (elastic#30018)
  Remove SSL3 support from libbeat and its documentation. (elastic#30071)
  Revert "Packaging: rename arm64 suffix to aarch64 in the tar.gz artifacts ONLY (elastic#28813)" (elastic#30083)
  [libbeat] Add script processor to all beats (elastic#29752)
  Add fonts to support more different types of characters for multiple languages (elastic#29861)
  libbeat/reader: Fix messge conversion to beat.Event (elastic#30057)
  probot[stale]: ignore issues with the tag flaky-test (elastic#30065)
  [DOCS] Add redirect for GSuite module (elastic#30034)
  [Automation] Update elastic stack version to 8.1.0-aa69d697 for testing (elastic#30012)
  Remove msitools install for windows build, using the latest docker image with msitools preinstalled (elastic#30040)
  filebeat/generator/fields: fix dropped error (elastic#29943)
  Include the error message with auditd module events (elastic#30009)
  [Metricbeat] gcp: add firestore metricset (elastic#29918)
  probot: update stale dates (elastic#29997)
  Metricbeat enterprise search module: add xpack.enabled support (elastic#29871)
  x-pack/packetbeat: install Npcap at start-up when required (elastic#29112)
  [Filebeat] Fix panic in decode_cef when recovering from invalid data (elastic#30038)
  Correctly fixe how selected packages are defined (elastic#30039)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz cmacknz approved these changes

Assignees

@cmacknz cmacknz

Labels

backport-skip Skip notification from the automated backport with mergify bug Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alrs @elasticmachine @cmacknz @mtojek @jlind23