Conversation
|
This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
NOTE: |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
/test |
michel-laterman
left a comment
There was a problem hiding this comment.
just a minor fix
| ) (gateway.FleetGateway, error) { | ||
|
|
||
| // Backoff implementation doesn't support the using context as the shutdown mechanism. | ||
| // Backoff implementation doesn't support the using of a context as the shutdown mechanism. |
There was a problem hiding this comment.
| // Backoff implementation doesn't support the using of a context as the shutdown mechanism. | |
| // Backoff implementation doesn't support the using cancellation of a context as the shutdown mechanism. |
Is this what is meant?
There was a problem hiding this comment.
Suggest either "Backoff implementation doesn't support using a context [cancellation] as the shutdown mechanism." or "Backoff implementation doesn't support the use of a context [cancellation] as the shutdown mechanism." (insert "cancellation" according to taste).
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
| // Types is the list of package types | ||
| var SelectedPackageTypes []PackageType | ||
| // SelectedPackageTypes is the list of package types | ||
| var SelectedPackageTypes []PackageType = []PackageType{TarGz} |
There was a problem hiding this comment.
Is this correct? The description mentioned comments only, but this is code?
I see failures in the packaging
There was a problem hiding this comment.
This was a mistake, but it's been fixed already by #30007.
What does this PR do?
It fixes some typos and Go conventions on the code's comments.
Why is it important?
To keep consistent with the standard English.
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.