Use the generic helper for opening file to read in filestream by kvch · Pull Request #29180 · elastic/beats

kvch · 2021-11-29T14:01:28Z

What does this PR do?

This PR uses the platform-dependent function to open files for harvesting.

Why is it important?

This change lets filestream input open files on Windows in a way it can be deleted.

Checklist

My code follows the style guidelines of this project
~~- [ ] I have commented my code, particularly in hard-to-understand areas~~
~~- [ ] I have made corresponding changes to the documentation~~
~~- [ ] I have made corresponding change to the default configuration files~~
~~- [ ] I have added tests that prove my fix is effective or that my feature works~~
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #29113

Closes elastic#29113

mergify · 2021-11-29T14:01:40Z

This pull request does not have a backport label. Could you fix it @kvch? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

elasticmachine · 2021-11-29T14:02:04Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine · 2021-11-29T15:46:17Z

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Reason: Aborted from #2
Start Time: 2021-11-29T14:01:50.227+0000
Duration: 104 min 12 sec
Commit: 60cfe1f

Test stats 🧪

Test	Results
Failed	0
Passed	9517
Skipped	1275
Total	10792

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Closes #29113 (cherry picked from commit 24d6bbd)

#29181) Closes #29113 (cherry picked from commit 24d6bbd) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>

#29182) Closes #29113 (cherry picked from commit 24d6bbd) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>

#29183) Closes #29113 (cherry picked from commit 24d6bbd) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>

* upstream/master: (577 commits) Remove Journalbeat (elastic#29131) Add note that there is no warranty or support for generator code (elastic#28797) packetbeat: preparation for npcap addition (elastic#29017) Use the generic helper for opening file to read in filestream (elastic#29180) Workflow for macos (elastic#29174) Fix `decode_json_fields` processor to always add error key (elastic#29107) Workflow for macos (elastic#29156) Fix agent download timeout values in yaml files (elastic#29039) Added workflow file for builds with macos (elastic#29148) CI: enable AWS cloud testing on a PR basis if changes in certain files (elastic#29047) Remove links to Journalbeat (elastic#29134) Fix rds metadata in cloudwatch metricset (elastic#29106) [mergify]: notify conflicts in PRs that are still open (elastic#29122) Use NamedWatcher in Agent's k8s provider (elastic#29095) override host on statsd metricset (elastic#29103) Skip config check in autodiscover for duplicated configurations (elastic#29048) Change "filebeat.config.modules.enabled" to "true" (elastic#28769) Remove deprecated spool queue from Beats (elastic#28869) Add `beat` field back to beat.stats (elastic#29094) Revert "Move labels and annotations under kubernetes.namespace. (elastic#27917)" (elastic#29069) ...

* upstream/master: [libbeat] Fix add_labels flattening of arrays values (elastic#29211) Change elastic-agent pprof default to false (elastic#29155) elastic#28472 fix flaky tests in libbeat fmtstr to use time.UTC instead of time.Local (elastic#28473) Adopt `parsers` in Filebeat's journald input (elastic#29070) [Elastic Agent] Add process error handling guidelines (elastic#29152) winlogbeat/sys/winevent: use reflect IsZero method (elastic#29190) Remove Journalbeat (elastic#29131) Add note that there is no warranty or support for generator code (elastic#28797) packetbeat: preparation for npcap addition (elastic#29017) Use the generic helper for opening file to read in filestream (elastic#29180) Workflow for macos (elastic#29174) Fix `decode_json_fields` processor to always add error key (elastic#29107)

dikshachauhan-qasource · 2022-02-15T11:54:07Z

Hi @kvch

Can you please share details with us on how we can validate this PR.

Thanks
QAS

…c#29180) (elastic#29181) Closes elastic#29113 (cherry picked from commit 4ed9211) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>

Use the generic helper for opening file to read

60cfe1f

Closes elastic#29113

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 29, 2021

kvch added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 29, 2021

mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 29, 2021

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 29, 2021

mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 29, 2021

kvch added backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Nov 29, 2021

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 29, 2021

mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 29, 2021

add changelog entry

4795d99

belimawr approved these changes Nov 29, 2021

View reviewed changes

kvch merged commit 24d6bbd into elastic:master Nov 29, 2021

mergify bot pushed a commit that referenced this pull request Nov 29, 2021

Use the generic helper for opening file to read in filestream (#29180)

351e647

Closes #29113 (cherry picked from commit 24d6bbd)

mergify bot mentioned this pull request Nov 29, 2021

[7.15](backport #29180) Use the generic helper for opening file to read in filestream #29181

Merged

mergify bot pushed a commit that referenced this pull request Nov 29, 2021

Use the generic helper for opening file to read in filestream (#29180)

70b9d90

Closes #29113 (cherry picked from commit 24d6bbd)

mergify bot mentioned this pull request Nov 29, 2021

[7.16](backport #29180) Use the generic helper for opening file to read in filestream #29182

Merged

mergify bot pushed a commit that referenced this pull request Nov 29, 2021

Use the generic helper for opening file to read in filestream (#29180)

2b9ed24

Closes #29113 (cherry picked from commit 24d6bbd)

mergify bot mentioned this pull request Nov 29, 2021

[8.0](backport #29180) Use the generic helper for opening file to read in filestream #29183

Merged

kvch added a commit that referenced this pull request Nov 30, 2021

Use the generic helper for opening file to read in filestream (#29180) (

100d7e2

#29181) Closes #29113 (cherry picked from commit 24d6bbd) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>

kvch added a commit that referenced this pull request Nov 30, 2021

Use the generic helper for opening file to read in filestream (#29180) (

abff3d2

#29182) Closes #29113 (cherry picked from commit 24d6bbd) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>

kvch added a commit that referenced this pull request Nov 30, 2021

Use the generic helper for opening file to read in filestream (#29180) (

ca309ef

#29183) Closes #29113 (cherry picked from commit 24d6bbd) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>

kvch mentioned this pull request Jan 10, 2022

cannot configure file rotation for Filebeat/Metricbeat specific logs under agent #27853

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use the generic helper for opening file to read in filestream#29180

Use the generic helper for opening file to read in filestream#29180
kvch merged 2 commits intoelastic:masterfrom
kvch:fix-filebeat-open-files-on-windows

kvch commented Nov 29, 2021 •

edited

Loading

Uh oh!

mergify bot commented Nov 29, 2021

Uh oh!

elasticmachine commented Nov 29, 2021

Uh oh!

elasticmachine commented Nov 29, 2021 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

Uh oh!

dikshachauhan-qasource commented Feb 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kvch commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Related issues

Uh oh!

mergify bot commented Nov 29, 2021

Uh oh!

elasticmachine commented Nov 29, 2021

Uh oh!

elasticmachine commented Nov 29, 2021 • edited by jenkins-beats-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❕ Build Aborted

Build stats

Test stats 🧪

🤖 GitHub comments

Uh oh!

dikshachauhan-qasource commented Feb 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kvch commented Nov 29, 2021 •

edited

Loading

elasticmachine commented Nov 29, 2021 •

edited by jenkins-beats-ci bot

Loading