Skip to content

override host on statsd metricset#29103

Merged
francescayeye merged 2 commits intoelastic:masterfrom
francescayeye:override-host-on-statsd-metricset
Nov 24, 2021
Merged

override host on statsd metricset#29103
francescayeye merged 2 commits intoelastic:masterfrom
francescayeye:override-host-on-statsd-metricset

Conversation

@francescayeye
Copy link
Copy Markdown

@francescayeye francescayeye commented Nov 23, 2021 •
edited
Loading

Enhancement

What does this PR do?

It adds Host() implementation for statsd metricset

Why is it important?

Host() returns the hostname or other module specific value that identifies a specific host or service instance from which to collect metrics.
In the BaseMetricSet implementation it uses the hosts field from config of the metricset.
statsd rather use host and port, so a different implementation is needed to report relevant information

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

{"log.level":"debug","@timestamp":"2021-11-23T18:44:13.426+0100","log.logger":"module","log.origin":{"file.name":"module/wrapper.go","file.line":189},"message":"Starting metricSetWrapper[module=statsd, name=server, host=127.0.0.1:8125]","service.name":"metricbeat","ecs.version":"1.6.0"}

{"log.level":"debug","@timestamp":"2021-11-23T18:45:37.777+0100","log.logger":"module","log.origin":{"file.name":"module/wrapper.go","file.line":189},"message":"Starting metricSetWrapper[module=airflow, name=statsd, host=127.0.0.1:8126]","service.name":"metricbeat","ecs.version":"1.6.0"}

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 23, 2021
@francescayeye francescayeye self-assigned this Nov 23, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 23, 2021

This pull request does not have a backport label. Could you fix it @aspacca? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 23, 2021
@francescayeye francescayeye added Team:Platforms Label for the Integrations - Platforms team and removed backport-skip Skip notification from the automated backport with mergify labels Nov 23, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 23, 2021

Pinging @elastic/integrations (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 23, 2021
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 23, 2021
@francescayeye francescayeye added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify labels Nov 23, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 23, 2021
@francescayeye francescayeye removed the backport-v7.15.0 Automated backport with mergify label Nov 23, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 23, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-23T17:49:31.112+0000

  • Duration: 107 min 33 sec

  • Commit: f7e664d

Test stats 🧪

Test Results
Failed 0
Passed 9755
Skipped 2528
Total 12283

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@francescayeye francescayeye merged commit 606a7d2 into elastic:master Nov 24, 2021
mergify bot pushed a commit that referenced this pull request Nov 24, 2021
override host on statsd metricset (#29103)
d31e215 
* override host on statsd metricset

* changelog

(cherry picked from commit 606a7d2)
@mergify mergify bot mentioned this pull request Nov 24, 2021
Merged
mergify bot pushed a commit that referenced this pull request Nov 24, 2021
override host on statsd metricset (#29103)
056839c 
* override host on statsd metricset

* changelog

(cherry picked from commit 606a7d2)
@mergify mergify bot mentioned this pull request Nov 24, 2021
Merged
v1v added a commit to v1v/beats that referenced this pull request Nov 24, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/support-a…
3c5dac0 
…ws-on-file-changes

* upstream/master:
  override host on statsd metricset (elastic#29103)
  Skip config check in autodiscover for duplicated configurations (elastic#29048)
  Change "filebeat.config.modules.enabled" to "true" (elastic#28769)
  Remove deprecated spool queue from Beats (elastic#28869)
  Add `beat` field back to beat.stats (elastic#29094)
  Revert "Move labels and annotations under kubernetes.namespace. (elastic#27917)" (elastic#29069)
  heartbeat: remove w2008 in the CI (elastic#29093)
  Remove deprecated `--template` and `--index-policy` flags (elastic#28870)
  Fix parsing of apache trace log levels (elastic#28717)
  [Elastic-Agent] IUse itnernal port for local fleet server (elastic#28993)
  [Heartbeat] Log error on dupe monitor ID instead of strict req (elastic#29041)
  Enable pprof for elastic-agent and beats (elastic#28983)
francescayeye pushed a commit that referenced this pull request Nov 24, 2021
@mergify
override host on statsd metricset (#29103) (#29120)
d28a893 
* override host on statsd metricset

* changelog

(cherry picked from commit 606a7d2)

Co-authored-by: Andrea Spacca <andrea.spacca@elastic.co>
francescayeye pushed a commit that referenced this pull request Nov 24, 2021
@mergify
override host on statsd metricset (#29103) (#29121)
6b4dc96 
* override host on statsd metricset

* changelog

(cherry picked from commit 606a7d2)

Co-authored-by: Andrea Spacca <andrea.spacca@elastic.co>
v1v added a commit to v1v/beats that referenced this pull request Nov 30, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/use-debian-9
53d5763 
* upstream/master: (577 commits)
  Remove Journalbeat (elastic#29131)
  Add note that there is no warranty or support for generator code (elastic#28797)
  packetbeat: preparation for npcap addition (elastic#29017)
  Use the generic helper for opening file to read in filestream (elastic#29180)
  Workflow for macos (elastic#29174)
  Fix `decode_json_fields` processor to always add error key (elastic#29107)
  Workflow for macos (elastic#29156)
  Fix agent download timeout values in yaml files (elastic#29039)
  Added workflow file for builds with macos (elastic#29148)
  CI: enable AWS cloud testing on a PR basis if changes in certain files (elastic#29047)
  Remove links to Journalbeat (elastic#29134)
  Fix rds metadata in cloudwatch metricset (elastic#29106)
  [mergify]: notify conflicts in PRs that are still open (elastic#29122)
  Use NamedWatcher in Agent's k8s provider (elastic#29095)
  override host on statsd metricset (elastic#29103)
  Skip config check in autodiscover for duplicated configurations (elastic#29048)
  Change "filebeat.config.modules.enabled" to "true" (elastic#28769)
  Remove deprecated spool queue from Beats (elastic#28869)
  Add `beat` field back to beat.stats (elastic#29094)
  Revert "Move labels and annotations under kubernetes.namespace. (elastic#27917)" (elastic#29069)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@francescayeye francescayeye

Labels

backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francescayeye @elasticmachine @kaiyan-sheng