Skip to content

CI: add GitHub actions for macos (push based)#29032

Merged
v1v merged 24 commits intoelastic:masterfrom
v1v:feature/add-github-for-macos
Jan 13, 2022
Merged

CI: add GitHub actions for macos (push based)#29032
v1v merged 24 commits intoelastic:masterfrom
v1v:feature/add-github-for-macos

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Nov 18, 2021 •
edited
Loading

What does this PR do?

Add the minimal GitHub actions for MacOS on a push based.

Why is it important?

Infra asked to evaluate this and the cost.

Issues

Notifies #28906 that will provide the integration with Jenkins and other better user experience

@v1v v1v added backport-v8.0.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Nov 18, 2021
@v1v v1v requested review from a team November 18, 2021 12:01
@v1v v1v self-assigned this Nov 18, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2021
@v1v v1v requested review from jlind23, jsoriano and ruflin November 18, 2021 12:03
@v1v v1v added automation Team:Automation Label for the Observability productivity team labels Nov 18, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2021
v1v
v1v commented Nov 18, 2021
View reviewed changes
mdelapenya
mdelapenya approved these changes Nov 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's possible to reuse workflows that are almost the same, calling them with input parameters from a caller workflow. See https://docs.github.com/en/actions/learn-github-actions/reusing-workflows

Other than that, LGTM

@jlind23
Copy link
Copy Markdown
Contributor

jlind23 commented Nov 18, 2021

What's the overall strategy? Migrate everything on GithubActions or only MacOS builds?

@v1v v1v requested review from a team and removed request for a team January 12, 2022 20:32
@v1v
Copy link
Copy Markdown
Member Author

v1v commented Jan 12, 2022 •
edited
Loading

Status update

I just reenabled this particular PR to be able to evaluate this approach in addition to the Orka one. It will run by default for every push in the 7., 8. and master branches

@v1v v1v marked this pull request as ready for review January 12, 2022 20:36
mdelapenya
mdelapenya reviewed Jan 13, 2022
View reviewed changes
@v1v v1v added backport-skip Skip notification from the automated backport with mergify and removed backport-v8.0.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Jan 13, 2022
@v1v v1v changed the title CI: add GitHub for macos CI: add GitHub actions for macos (push based) Jan 13, 2022
@v1v v1v merged commit 6c40884 into elastic:master Jan 13, 2022
@v1v v1v added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jan 13, 2022
@v1v
Copy link
Copy Markdown
Member Author

v1v commented Jan 13, 2022

I thought the backport was not needed as long as the default branch contained the github actions with the on: pushed: branches: ... but that's not the case

OTOH, interestingly, the auditbeat on macos worked for this PR but it's not the case anymore for the main branch!

@mergify mergify bot mentioned this pull request Jan 13, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jan 13, 2022
@v1v
CI: add GitHub actions for macos (push based) (#29032)
7ed1886 
(cherry picked from commit 6c40884)
mergify bot pushed a commit that referenced this pull request Jan 13, 2022
@v1v
CI: add GitHub actions for macos (push based) (#29032)
195eece 
(cherry picked from commit 6c40884)
@mergify mergify bot mentioned this pull request Jan 13, 2022
Merged
v1v added a commit that referenced this pull request Jan 13, 2022
@mergify @v1v
CI: add GitHub actions for macos (push based) (#29032) (#29846)
a85b0fd 
(cherry picked from commit 6c40884)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit that referenced this pull request Jan 13, 2022
@mergify @v1v
CI: add GitHub actions for macos (push based) (#29032) (#29845)
fecc0c2 
(cherry picked from commit 6c40884)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@matschaffer matschaffer mentioned this pull request Feb 22, 2022
Merged
@v1v v1v mentioned this pull request Jul 21, 2022
Merged
@v1v v1v mentioned this pull request Mar 25, 2024
Closed
6 tasks
@v1v v1v mentioned this pull request Mar 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@jlind23 jlind23 Awaiting requested review from jlind23

@jsoriano jsoriano Awaiting requested review from jsoriano

@ruflin ruflin Awaiting requested review from ruflin

@nkammah nkammah Awaiting requested review from nkammah

+1 more reviewer

@mdelapenya mdelapenya mdelapenya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v1v v1v

Labels

automation backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify Team:Automation Label for the Observability productivity team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@v1v @jlind23 @elasticmachine @mdelapenya @kuisathaverat