Added Github actions workflow to build on MacOS by nxei · Pull Request #28906 · elastic/beats

nxei · 2021-11-10T08:48:31Z

What does this PR do?

Add Github actions workflow to build on MacOS on a PR basis and being triggered by the Jenkins pipeline.

It runs as part of the mandatory meta-stage

#29032 is another implementation, which one do we enable?

Why is it important?

Delegate the environmental issues to the SaaS.
Ensure the OS coverage happens on a PR basis to avoid merging any PRs that could cause any regression.
Avoid being blocked from the system owner.

Issues

Superseedes #29032

UI

A Github check with the build status will be created:

Further details

GitHub already provides MacOS support:

mergify · 2021-11-10T08:49:05Z

This pull request does not have a backport label. Could you fix it @nxei? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

elasticmachine · 2021-11-10T09:05:32Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-12-06T11:01:30.981+0000
Duration: 194 min 2 sec
Commit: d22c392

Test stats 🧪

Test	Results
Failed	0
Passed	50923
Skipped	4485
Total	55408

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

This reverts commit 01e2e14.

Jenkinsfile

auditbeat/Jenkinsfile.yml

v1v

You can speed up your testing as commented sometime offline by changing the Jenkinsfile.yml top level file and remove all the projects but the one you are testing at the moment. In this case auditbeat/

Jenkinsfile

auditbeat/Jenkinsfile.yml

Jenkinsfile

Added macosActions stage to config for auditbeat.

.github/workflows/build.yml

nxei · 2021-11-26T09:52:09Z

/test

Jenkinsfile

v1v · 2021-11-30T12:47:36Z

Jenkinsfile

+      log(level: 'INFO', text: "Github build link: ${result.html_url}")
+      log(level: 'INFO', text: "Github build status: ${result.conclusion}")


I saw the build worked, awesome!

I think we can now add a conclusion validation if not success then report an error? IIUC, result.conclusion contains success if it successfully ran.

So something like the below snippet could work:

if (!result.conclusion.equals('success') { error(''${args.context}: ${result.conclusion}. See ${result.html_url}") }

What do you think?

OTOH, is the conclusion related to a run or a step?

I see steps.<step id>.conclusion in https://docs.github.com/en/actions/learn-github-actions/contexts#steps-context versus job.status in https://docs.github.com/en/actions/learn-github-actions/contexts#job-context. The conclusion is the status for the whole run? Where can I see all the fields for the result object?

* upstream/master: [libbeat] Fix add_labels flattening of arrays values (elastic#29211) Change elastic-agent pprof default to false (elastic#29155) elastic#28472 fix flaky tests in libbeat fmtstr to use time.UTC instead of time.Local (elastic#28473) Adopt `parsers` in Filebeat's journald input (elastic#29070) [Elastic Agent] Add process error handling guidelines (elastic#29152) winlogbeat/sys/winevent: use reflect IsZero method (elastic#29190) Remove Journalbeat (elastic#29131) Add note that there is no warranty or support for generator code (elastic#28797) packetbeat: preparation for npcap addition (elastic#29017) Use the generic helper for opening file to read in filestream (elastic#29180) Workflow for macos (elastic#29174) Fix `decode_json_fields` processor to always add error key (elastic#29107)

…lation

This reverts commit 2d04883.

v1v · 2021-12-01T18:02:42Z

metricbeat/Jenkinsfile.yml

    crosscompile:
        make: "make -C metricbeat crosscompile"
        stage: mandatory
+    macosAction:


#29038 most likely will cause an issue

metricbeat/Jenkinsfile.yml

v1v · 2021-12-06T11:00:48Z

/test

mergify · 2022-01-04T09:46:28Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b github-actions-build upstream/github-actions-build
git merge upstream/master
git push upstream github-actions-build

jlind23 · 2022-03-31T16:53:25Z

@v1v @cachedout what should we do with this PR? Is this still relevant or should I discard it?

v1v · 2022-03-31T16:57:58Z

I'll close this now, we have already put in place the GitHub actions on MacOS though they are not reported in Jenkins nor the github build comment, so we will need to revisit this in the future if needed

Added Github actions workflow to build on MacOS

e90d7a7

nxei added the enhancement label Nov 10, 2021

nxei requested a review from v1v November 10, 2021 08:48

nxei self-assigned this Nov 10, 2021

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 10, 2021

mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 10, 2021

v1v added automation backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify Team:Automation Label for the Observability productivity team labels Nov 10, 2021

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 10, 2021

mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 10, 2021

v1v added 4 commits November 10, 2021 09:06

CI: add githubAction function

dda1ffc

Enable GitHub actions for auditbeat

132de4e

Add when condition

01e2e14

Revert "Add when condition"

35c8b1b

This reverts commit 01e2e14.

v1v reviewed Nov 10, 2021

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

v1v reviewed Nov 16, 2021

View reviewed changes

auditbeat/Jenkinsfile.yml Outdated Show resolved Hide resolved

v1v mentioned this pull request Nov 18, 2021

CI: add GitHub actions for macos (push based) #29032

Merged

Added githubWorkflowRun call trigger build

e3c6695

v1v reviewed Nov 24, 2021

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

auditbeat/Jenkinsfile.yml Outdated Show resolved Hide resolved

v1v reviewed Nov 24, 2021

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

updated configs - disabled all projects except auditbeat.

2d04883

Added macosActions stage to config for auditbeat.

nxei mentioned this pull request Nov 25, 2021

Added workflow file for builds with macos #29148

Merged

6 tasks

v1v reviewed Nov 25, 2021

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

nxei and others added 3 commits November 25, 2021 17:00

removed workflow file

b946bda

changed ref to env.TARGET_BRANCH

3608eae

Merge branch 'elastic:master' into github-actions-build

c9481d0

v1v reviewed Nov 26, 2021

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

v1v reviewed Nov 26, 2021

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

nxei and others added 2 commits November 26, 2021 13:25

removed repo parameter and changed workflow file

475542a

Merge branch 'elastic:master' into github-actions-build

3d9c9c6

v1v reviewed Nov 29, 2021

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

v1v reviewed Nov 29, 2021

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

removed comment

bc05e65

v1v reviewed Nov 30, 2021

View reviewed changes

v1v added 8 commits December 1, 2021 09:38

print the object

006c126

ci: use low level withGithubStatus to support GH action status manipu…

ce2b110

…lation

Declare earlier

7ea1023

Run within the closure context

e087ce5

Use the right env variable

e68394a

Revert "updated configs - disabled all projects except auditbeat."

1844e0d

This reverts commit 2d04883.

Add macos

ffeffc5

v1v marked this pull request as ready for review December 1, 2021 18:02

v1v requested review from a team as code owners December 1, 2021 18:02

v1v reviewed Dec 1, 2021

View reviewed changes

v1v requested a review from a team December 1, 2021 18:02

v1v reviewed Dec 2, 2021

View reviewed changes

metricbeat/Jenkinsfile.yml Outdated Show resolved Hide resolved

Update metricbeat/Jenkinsfile.yml

d22c392

v1v closed this Mar 31, 2022

		log(level: 'INFO', text: "Github build link: ${result.html_url}")
		log(level: 'INFO', text: "Github build status: ${result.conclusion}")

Conversation

nxei commented Nov 10, 2021 • edited by v1v Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Issues

UI

Further details

Uh oh!

mergify bot commented Nov 10, 2021

Uh oh!

elasticmachine commented Nov 10, 2021 • edited by jenkins-beats-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

Uh oh!

Uh oh!

Uh oh!

v1v left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nxei commented Nov 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

v1v Nov 30, 2021

Choose a reason for hiding this comment

Uh oh!

v1v Dec 1, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

v1v commented Dec 6, 2021

Uh oh!

mergify bot commented Jan 4, 2022

Uh oh!

jlind23 commented Mar 31, 2022

Uh oh!

v1v commented Mar 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nxei commented Nov 10, 2021 •

edited by v1v

Loading

elasticmachine commented Nov 10, 2021 •

edited by jenkins-beats-ci bot

Loading