[mergify] report open backported PRs once a week#28964
Conversation
|
This pull request does not have a backport label. Could you fix it @v1v? 🙏
NOTE: |
ruflin
left a comment
There was a problem hiding this comment.
LGTM.
I initially was thinking it puts a reminder after it is stale for a week but I can see how it makes the implementation much more complicated. Lets go with the pings each Monday.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
jsoriano
left a comment
There was a problem hiding this comment.
👍 added some comments and questions, nothing blocker.
| actions: | ||
| comment: | ||
| message: | | ||
| This pull request has not been merged yet. Could you please review and merge it @{{ assignee | join(', @') }}? 🙏 |
There was a problem hiding this comment.
Some backports don't have an assignee (for example #28783), should we have a different action for these ones? (Not sure which one)
There was a problem hiding this comment.
We could create a new one to add a team by default if no assignee?
There was a problem hiding this comment.
Ok, but I don't know who should be pinged on this action. We can leave this for a follow up.
The only thing to consider here is that assignee may be empty, do we still want to add a comment in this case? It will generate a message like:
This pull request has not been merged yet. Could you please review and merge it @? 🙏
There was a problem hiding this comment.
Not reported anymore to those PRs without an assignee. We will work on this in the future with another rule to notify to a more broadly team, maybe...
| actions: | ||
| comment: | ||
| message: | | ||
| This pull request has not been merged yet. Could you please review and merge it @{{ assignee | join(', @') }}? 🙏 |
There was a problem hiding this comment.
Ok, but I don't know who should be pinged on this action. We can leave this for a follow up.
The only thing to consider here is that assignee may be empty, do we still want to add a comment in this case? It will generate a message like:
This pull request has not been merged yet. Could you please review and merge it @? 🙏
…ws-on-file-changes * upstream/master: Fix discovery of Nomad allocations (elastic#28700) Add null (`\u0000`) as a valid line terminator (elastic#28998) Remove `logging.files.suffix` option and always use datetime suffixes (elastic#28927) x-pack/filebeat/module: add note for default var.input (elastic#28324) Fix AccessList & AccessMask processing in security data_stream (elastic#29016) [Metricbeat] Fix wrong mapping on "info" subkey (elastic#28782) ci: daily/weekly jobs (elastic#29050) [mergify] report open backported PRs once a week (elastic#28964)
What does this PR do?
Notify to the
assigneeswhen an automated backport Pull Request has not been merged yet.When?:
mergifyWhy is it important?
Avoid missing backports.
UI
See elastic/apm-pipeline-library#1380 (comment)