Skip to content

x-pack/filebeat/module: add note for default var.input#28324

Merged
efd6 merged 1 commit intoelastic:masterfrom
efd6:defaultnotes
Nov 21, 2021
Merged

x-pack/filebeat/module: add note for default var.input#28324
efd6 merged 1 commit intoelastic:masterfrom
efd6:defaultnotes

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Oct 11, 2021

What does this PR do?

This adds a note to relevant var.input config fields saying what the default is. In all cases, this is udp.

Why is it important?

This fixes a user concern.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Confirm that all noted UDP defaults actually default to UDP.

How to test this PR locally

make -C filebeat check;make -C filebeat update;make -C x-pack/filebeat check;make -C x-pack/filebeat update;make check-no-changes

Related issues

Use cases

N/A

Screenshots

N/A

Logs

N/A

[git-generate]
find x-pack/filebeat/module -type f -name '*.asciidoc' -exec gsed -i -r 's/(The input from which messages are read\. One of `file`, `tcp` or `udp`\.)/\1 Defaults to `udp`./g' {} \;
make update
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 11, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 11, 2021

This pull request does not have a backport label. Could you fix it @efd6? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 11, 2021
@efd6 efd6 added 7.16 candidate enhancement Team:Security-External Integrations and removed backport-skip Skip notification from the automated backport with mergify labels Oct 11, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 11, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 11, 2021

This pull request does not have a backport label. Could you fix it @efd6? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 11, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-11T01:43:28.513+0000

  • Duration: 22 min 8 sec

  • Commit: f660e17

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@efd6 efd6 added backport-v7.16.0 Automated backport with mergify and removed 7.16 candidate backport-skip Skip notification from the automated backport with mergify labels Oct 11, 2021
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good addition to the docs.

@botelastic
Copy link
Copy Markdown

botelastic bot commented Nov 20, 2021

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Nov 20, 2021
@efd6 efd6 merged commit 1e762cc into elastic:master Nov 21, 2021
@efd6 efd6 added backport-v8.0.0 Automated backport with mergify and removed backport-v7.16.0 Automated backport with mergify labels Nov 21, 2021
mergify bot pushed a commit that referenced this pull request Nov 21, 2021
[git-generate]
find x-pack/filebeat/module -type f -name '*.asciidoc' -exec gsed -i -r 's/(The input from which messages are read\. One of `file`, `tcp` or `udp`\.)/\1 Defaults to `udp`./g' {} \;
make update

(cherry picked from commit 1e762cc)
mergify bot pushed a commit that referenced this pull request Nov 21, 2021
[git-generate]
find x-pack/filebeat/module -type f -name '*.asciidoc' -exec gsed -i -r 's/(The input from which messages are read\. One of `file`, `tcp` or `udp`\.)/\1 Defaults to `udp`./g' {} \;
make update

(cherry picked from commit 1e762cc)
efd6 added a commit that referenced this pull request Nov 21, 2021
[git-generate]
find x-pack/filebeat/module -type f -name '*.asciidoc' -exec gsed -i -r 's/(The input from which messages are read\. One of `file`, `tcp` or `udp`\.)/\1 Defaults to `udp`./g' {} \;
make update

(cherry picked from commit 1e762cc)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
efd6 added a commit that referenced this pull request Nov 22, 2021
[git-generate]
find x-pack/filebeat/module -type f -name '*.asciidoc' -exec gsed -i -r 's/(The input from which messages are read\. One of `file`, `tcp` or `udp`\.)/\1 Defaults to `udp`./g' {} \;
make update

(cherry picked from commit 1e762cc)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
v1v added a commit to v1v/beats that referenced this pull request Nov 22, 2021
…ws-on-file-changes

* upstream/master:
  Fix discovery of Nomad allocations (elastic#28700)
  Add null (`\u0000`) as a valid line terminator (elastic#28998)
  Remove `logging.files.suffix` option and always use datetime suffixes (elastic#28927)
  x-pack/filebeat/module: add note for default var.input (elastic#28324)
  Fix AccessList & AccessMask processing in security data_stream (elastic#29016)
  [Metricbeat] Fix wrong mapping on "info" subkey (elastic#28782)
  ci: daily/weekly jobs (elastic#29050)
  [mergify] report open backported PRs once a week (elastic#28964)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v8.0.0 Automated backport with mergify enhancement Stalled

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation enhancement: Sonicwall beat

4 participants