Skip to content

Remove network and diskio metrics from ec2 metricset#28316

Merged
kaiyan-sheng merged 3 commits intoelastic:masterfrom
kaiyan-sheng:remove_fields_ec2
Oct 19, 2021
Merged

Remove network and diskio metrics from ec2 metricset#28316
kaiyan-sheng merged 3 commits intoelastic:masterfrom
kaiyan-sheng:remove_fields_ec2

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 7, 2021 •
edited
Loading

What does this PR do?

With #13203, rate metrics are calculated based on network and diskio metrics. With the new rate metrics, original metrics can be removed in 8.0.0. The default ec2 dashboard need to be changed as well.

closes #13359

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 7, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 7, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 7, 2021

This pull request does not have a backport label. Could you fix it @kaiyan-sheng? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 7, 2021
@kaiyan-sheng kaiyan-sheng mentioned this pull request Oct 7, 2021
Closed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 7, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-19T13:58:46.161+0000

  • Duration: 80 min 19 sec

  • Commit: 7de8b83

Test stats 🧪

Test Results
Failed 0
Passed 2666
Skipped 248
Total 2914

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@kaiyan-sheng kaiyan-sheng added the Team:Integrations Label for the Integrations team label Oct 8, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 8, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 8, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 12, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove_fields_ec2 upstream/remove_fields_ec2
git merge upstream/master
git push upstream remove_fields_ec2

@kaiyan-sheng kaiyan-sheng merged commit d932bc9 into elastic:master Oct 19, 2021
@kaiyan-sheng kaiyan-sheng deleted the remove_fields_ec2 branch October 19, 2021 15:22
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Remove network and diskio metrics from ec2 metricset (elastic#28316)
65c5501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@francescayeye francescayeye francescayeye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

backport-skip Skip notification from the automated backport with mergify Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Metricbeat] Remove network and diskio metrics from ec2 metricset

3 participants

@kaiyan-sheng @elasticmachine @francescayeye