Add calculate_rate for NetworkIn/Out, DiskRead/WriteBytes and DiskRead/WriteOps#13203
Merged
kaiyan-sheng merged 4 commits intoelastic:masterfrom Aug 18, 2019
kaiyan-sheng:calculate_ec2
Merged
Add calculate_rate for NetworkIn/Out, DiskRead/WriteBytes and DiskRead/WriteOps#13203kaiyan-sheng merged 4 commits intoelastic:masterfrom kaiyan-sheng:calculate_ec2
kaiyan-sheng merged 4 commits intoelastic:masterfrom
kaiyan-sheng:calculate_ec2
Conversation
Contributor
Author
|
If detailed monitoring is enabled, then these metrics will be sent to Cloudwatch every 1 min instead of every 5min. The rate calculated here is for each data point, which has nothing to do with the collection period that user sets in Metricbeat aws module. Therefore this calculation doesn't seem to be able to replace by adding collection period into each event. @jsoriano What do you think? |
jsoriano
reviewed
Aug 16, 2019
Member
jsoriano
left a comment
There was a problem hiding this comment.
Added some comments, and this will also need a changelog entry.
jsoriano
reviewed
Aug 17, 2019
Member
jsoriano
left a comment
There was a problem hiding this comment.
It LGTM, but it needs a changelog entry.
jsoriano
approved these changes
Aug 17, 2019
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to try solve elastic/kibana#42687 in metricbeat side.
In ec2 metricset, adding a config parameter called
calculate_rateto calculate rates for 8 metrics:network.in.bytes_per_sec = network.in.bytes / 300 or network.in.bytes / 60
network.out.bytes_per_sec = network.out.bytes / 300 or network.out.bytes / 60
network.in.packets_per_sec = network.in.packets / 300 or network.in.bytes / 60
network.out.packets_per_sec = network.out.packets / 300 or network.out.bytes / 60
diskio.read.bytes_per_sec = diskio.read.bytes / 300 or diskio.read.bytes / 60
diskio.write.bytes_per_sec = diskio.write.bytes / 300 or diskio.write.bytes / 60
diskio.read.ops_per_sec = diskio.read.ops / 300 or diskio.read.ops / 60
diskio.write.ops_per_sec = diskio.write.ops / 300 or diskio.write.ops / 60
Right now both the original metrics and the rate metrics are reported by
ec2metricset, in the future, the original metrics will be removed.