Skip to content

Be more lenient when checking for Saved Objects API in Kibana#27460

Merged
kvch merged 3 commits intoelastic:masterfrom
kvch:fix-libbeat-lenient-kibana-version-for-dashboards
Aug 18, 2021
Merged

Be more lenient when checking for Saved Objects API in Kibana#27460
kvch merged 3 commits intoelastic:masterfrom
kvch:fix-libbeat-lenient-kibana-version-for-dashboards

Conversation

@kvch
Copy link
Copy Markdown
Contributor

@kvch kvch commented Aug 18, 2021

What does this PR do?

This PR sets the minimum required version for Kibana to 7.14 for using the Saved Objects API. The change lets module developers use the last released version for exporting dashboards.

The PR also updates the testing environment to 7.14, so dashboard exporting and importing can be tested using e2e tests.

Why is it important?

Support module developers and run e2e tests to catch issues.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Requires #27424

@kvch kvch added Team:Elastic-Agent Label for the Agent team backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Aug 18, 2021
@kvch kvch requested a review from jsoriano August 18, 2021 10:21
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 18, 2021
Copy link
Copy Markdown
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM if it goes green.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have been updated after 7.13 and 7.14 releases?

@andresrc should we review the release process? We may also want to include there the update of the Metricbeat environments (changes like this recent one #27416).

@kvch
Copy link
Copy Markdown
Contributor Author

kvch commented Aug 18, 2021

jenkins run tests

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 18, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-18T13:09:43.304+0000

  • Duration: 148 min 36 sec

  • Commit: ca03595

Test stats 🧪

Test Results
Failed 0
Passed 53368
Skipped 5320
Total 58688

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 53368
Skipped 5320
Total 58688

@kvch kvch force-pushed the fix-libbeat-lenient-kibana-version-for-dashboards branch from 9056f1d to e9e6d93 Compare August 18, 2021 12:30
@ruflin ruflin added the backport-v7.14.0 Automated backport with mergify label Aug 18, 2021
@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Aug 18, 2021

Added 7.14 backport label to make sure it also gets backported to 7.14

@jsoriano
Copy link
Copy Markdown
Member

Added 7.14 backport label to make sure it also gets backported to 7.14

I don't think we should backport changes related to saved objects to a released branch. Or do you mean to backport the upgrade of the versions in the testing scenarios?

@kvch kvch removed the backport-v7.14.0 Automated backport with mergify label Aug 18, 2021
@kvch
Copy link
Copy Markdown
Contributor Author

kvch commented Aug 18, 2021

@ruflin This should not be backported to 7.14, but to 7.15.

@kvch kvch merged commit 9defc4a into elastic:master Aug 18, 2021
mergify bot pushed a commit that referenced this pull request Aug 18, 2021
## What does this PR do?

This PR sets the minimum required version for Kibana to 7.14 for using the Saved Objects API. The change lets module developers use the last released version for exporting dashboards.

The PR also updates the testing environment to 7.14, so dashboard exporting and importing can be tested using e2e tests.

## Why is it important?

Support module developers and run e2e tests to catch issues.

(cherry picked from commit 9defc4a)
kvch added a commit that referenced this pull request Aug 18, 2021
This PR sets the minimum required version for Kibana to 7.14 for using the Saved Objects API. The change lets module developers use the last released version for exporting dashboards.

The PR also updates the testing environment to 7.14, so dashboard exporting and importing can be tested using e2e tests.

Support module developers and run e2e tests to catch issues.

(cherry picked from commit 9defc4a)
kvch added a commit that referenced this pull request Aug 19, 2021
#27471)

## What does this PR do?

This PR sets the minimum required version for Kibana to 7.14 for using the Saved Objects API. The change lets module developers use the last released version for exporting dashboards.

The PR also updates the testing environment to 7.14, so dashboard exporting and importing can be tested using e2e tests.

## Why is it important?

Support module developers and run e2e tests to catch issues.

(cherry picked from commit 9defc4a)

Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
kvch added a commit that referenced this pull request Aug 19, 2021
#27470)

This PR sets the minimum required version for Kibana to 7.14 for using the Saved Objects API. The change lets module developers use the last released version for exporting dashboards.

The PR also updates the testing environment to 7.14, so dashboard exporting and importing can be tested using e2e tests.

Support module developers and run e2e tests to catch issues.

(cherry picked from commit 9defc4a)

Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
…c#27460)

## What does this PR do?

This PR sets the minimum required version for Kibana to 7.14 for using the Saved Objects API. The change lets module developers use the last released version for exporting dashboards.

The PR also updates the testing environment to 7.14, so dashboard exporting and importing can be tested using e2e tests.

## Why is it important?

Support module developers and run e2e tests to catch issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants