Do not overwrite content type if it is multipart in Kibana loader#27424
Merged
kvch merged 3 commits intoelastic:masterfrom Aug 18, 2021
Merged
Do not overwrite content type if it is multipart in Kibana loader#27424kvch merged 3 commits intoelastic:masterfrom
kvch merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/agent (Team:Agent) |
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 53258 |
| Skipped | 5320 |
| Total | 58578 |
Contributor
Author
|
jenkins run tests |
ruflin
reviewed
Aug 18, 2021
Contributor
ruflin
left a comment
There was a problem hiding this comment.
You mention in the PR description index templates? Should this be index pattern?
|
|
||
| } | ||
|
|
||
| func TestNewKibanaClientWithMultipartData(t *testing.T) { |
Contributor
Author
|
I fixed the PR description. I indeed meant index pattern. |
jsoriano
reviewed
Aug 18, 2021
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
jsoriano
approved these changes
Aug 18, 2021
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
…7424) ## What does this PR do? This PR fixes dashboard loading. Kibana loader overwrites every content type to application/json. However, for multipart file transfer it has to be set to multipart/formdata and application/ndjson. Otherwise, loading the assets fails. Also, a module file has not been updated with new dashboard names. (cherry picked from commit 47c0c72)
Contributor
|
@kvch 7.14 branch has been created, please make sure it is also backported there. |
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
…7424) ## What does this PR do? This PR fixes dashboard loading. Kibana loader overwrites every content type to application/json. However, for multipart file transfer it has to be set to multipart/formdata and application/ndjson. Otherwise, loading the assets fails. Also, a module file has not been updated with new dashboard names. (cherry picked from commit 47c0c72) # Conflicts: # libbeat/kibana/client.go
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
…7424) ## What does this PR do? This PR fixes dashboard loading. Kibana loader overwrites every content type to application/json. However, for multipart file transfer it has to be set to multipart/formdata and application/ndjson. Otherwise, loading the assets fails. Also, a module file has not been updated with new dashboard names. (cherry picked from commit 47c0c72)
Contributor
|
@kvch Confusion on my end. I created the 7.15 branch and please double check it also went there and not only into 7.x |
kvch
added a commit
that referenced
this pull request
Aug 18, 2021
…7424) (#27461) ## What does this PR do? This PR fixes dashboard loading. Kibana loader overwrites every content type to application/json. However, for multipart file transfer it has to be set to multipart/formdata and application/ndjson. Otherwise, loading the assets fails. Also, a module file has not been updated with new dashboard names. (cherry picked from commit 47c0c72) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
kvch
added a commit
that referenced
this pull request
Aug 19, 2021
…7424) (#27464) ## What does this PR do? This PR fixes dashboard loading. Kibana loader overwrites every content type to application/json. However, for multipart file transfer it has to be set to multipart/formdata and application/ndjson. Otherwise, loading the assets fails. Also, a module file has not been updated with new dashboard names. (cherry picked from commit 47c0c72) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
|
This didn't make BC1 for 7.15.0 - https://staging.elastic.co/7.15.0-d9929120/summary-7.15.0.html thanks! |
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
…astic#27424) ## What does this PR do? This PR fixes dashboard loading. Kibana loader overwrites every content type to application/json. However, for multipart file transfer it has to be set to multipart/formdata and application/ndjson. Otherwise, loading the assets fails. Also, a module file has not been updated with new dashboard names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes dashboard loading. Kibana loader overwrites every content type to application/json. However, for multipart file transfer it has to be set to multipart/formdata and application/ndjson. Otherwise, loading the assets fails.
Also, a module file has not been updated with new dashboard names.
Why is it important?
Index pattern and dashboard loading was not working.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Closes #27418
Closes #27417