Skip to content

Use aws sdk paginator for FilterLogEvents and GetMetricData#26852

Merged
kaiyan-sheng merged 4 commits intoelastic:masterfrom
kaiyan-sheng:aws_cloudwatch_paginator
Jul 19, 2021
Merged

Use aws sdk paginator for FilterLogEvents and GetMetricData#26852
kaiyan-sheng merged 4 commits intoelastic:masterfrom
kaiyan-sheng:aws_cloudwatch_paginator

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 12, 2021 •
edited
Loading

What does this PR do?

This PR refactors AWS related code to use AWS SDK paginators instead.

  1. In Filebeat aws-cloudwatch input, change FilterLogEvents API to use NewFilterLogEventsPaginator.
  2. In Metricbeat, change GetMetricData to use NewGetMetricDataPaginator.
  3. In Metricbeat, change ListMetrics to use NewListMetricsPaginator.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 12, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 12, 2021
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team labels Jul 12, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 12, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 12, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 12, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-15T12:55:20.659+0000

  • Duration: 97 min 10 sec

  • Commit: f439f96

Test stats 🧪

Test Results
Failed 0
Passed 10358
Skipped 1489
Total 11847

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 10358
Skipped 1489
Total 11847

@francescayeye
Copy link
Copy Markdown

francescayeye commented Jul 16, 2021

@kaiyan-sheng reviewed and tested, LGTM

@francescayeye
Copy link
Copy Markdown

francescayeye commented Jul 19, 2021

+1

@kaiyan-sheng kaiyan-sheng merged commit 683130a into elastic:master Jul 19, 2021
@kaiyan-sheng kaiyan-sheng deleted the aws_cloudwatch_paginator branch July 19, 2021 14:00
@kaiyan-sheng kaiyan-sheng mentioned this pull request Jul 19, 2021
Merged
6 tasks
@kaiyan-sheng kaiyan-sheng added v7.15.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jul 19, 2021
@kaiyan-sheng kaiyan-sheng mentioned this pull request Jul 19, 2021
Merged
6 tasks
kaiyan-sheng pushed a commit that referenced this pull request Jul 19, 2021
Use aws sdk paginator for FilterLogEvents and GetMetricData (#26852) (#…
95a624c 
…26962)

(cherry picked from commit 683130a)
kaiyan-sheng pushed a commit that referenced this pull request Jul 19, 2021
Use aws sdk paginator for FilterLogEvents and GetMetricData (#26852) (#…
cab0971 
…26963)

(cherry picked from commit 683130a)
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jul 20, 2021
@mdelapenya
Merge branch 'master' into archive-system-tests
05ab4ab 
* master:
  Forward port 7.13.4 to master (elastic#26971)
  Use MustAddMetricSet in all metricsets (elastic#26907)
  add_process_metadata: enrich process info with process owner (elastic#21068) (elastic#21111)
  Use aws sdk paginator for FilterLogEvents and GetMetricData (elastic#26852)
  [Filebeat] Allow - for source IP for AWS S3 Access pipeline (elastic#26940)
  Increase timeout to 30secs (elastic#26841)
  Add Cluster filter on Kubernetes Overview ECS dashboard (elastic#26919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@francescayeye francescayeye francescayeye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

Team:Integrations Label for the Integrations team v7.14.0 v7.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filebeat aws-cloudwatch input missing logs

3 participants

@kaiyan-sheng @elasticmachine @francescayeye