Skip to content

Cherry-pick #26852 to 7.14: Use aws sdk paginator for FilterLogEvents and GetMetricData#26963

Merged
kaiyan-sheng merged 1 commit intoelastic:7.14from
kaiyan-sheng:backport_26852_7.14
Jul 19, 2021
Merged

Cherry-pick #26852 to 7.14: Use aws sdk paginator for FilterLogEvents and GetMetricData#26963
kaiyan-sheng merged 1 commit intoelastic:7.14from
kaiyan-sheng:backport_26852_7.14

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 19, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #26852 to 7.14 branch. Original message:

What does this PR do?

This PR refactors AWS related code to use AWS SDK paginators instead.

  1. In Filebeat aws-cloudwatch input, change FilterLogEvents API to use NewFilterLogEventsPaginator.
  2. In Metricbeat, change GetMetricData to use NewGetMetricDataPaginator.
  3. In Metricbeat, change ListMetrics to use NewListMetricsPaginator.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 19, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 19, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-19T16:45:40.456+0000

  • Duration: 98 min 14 sec

  • Commit: f4d413d

Test stats 🧪

Test Results
Failed 0
Passed 9342
Skipped 1450
Total 10792

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9342
Skipped 1450
Total 10792

@kaiyan-sheng kaiyan-sheng merged commit cab0971 into elastic:7.14 Jul 19, 2021
@kaiyan-sheng kaiyan-sheng deleted the backport_26852_7.14 branch July 19, 2021 18:48
@zube zube bot removed the [zube]: Done label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

backport Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaiyan-sheng @elasticmachine