Check native environment before starting#25186
Merged
urso merged 3 commits intoelastic:masterfrom Apr 21, 2021
Merged
Conversation
Running Beats/Agent build for 32bits sometimes leads to problems on 64bit platforms. Some system metrics do have different sizing on 32 and 64bit architectures, which can trip up Agent/Beats wrongly interpreting the given data. On Windows/Linux it is possible to run 32bit binaries. Now a check will be run to fail on startup if the architecture does not match the binaries architecture.
Contributor
|
Pinging @elastic/agent (Team:Agent) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
ph
approved these changes
Apr 21, 2021
Contributor
ph
left a comment
There was a problem hiding this comment.
Strategy looks good to me.
TIL about Linux 32 bits
mergify bot
pushed a commit
that referenced
this pull request
Apr 21, 2021
Running Beats/Agent build for 32bits sometimes leads to problems on 64bit platforms. Some system metrics do have different sizing on 32 and 64bit architectures, which can trip up Agent/Beats wrongly interpreting the given data. On Windows/Linux it is possible to run 32bit binaries. Now a check will be run to fail on startup if the architecture does not match the binaries architecture. (cherry picked from commit 7253026)
mergify bot
pushed a commit
that referenced
this pull request
Apr 21, 2021
Running Beats/Agent build for 32bits sometimes leads to problems on 64bit platforms. Some system metrics do have different sizing on 32 and 64bit architectures, which can trip up Agent/Beats wrongly interpreting the given data. On Windows/Linux it is possible to run 32bit binaries. Now a check will be run to fail on startup if the architecture does not match the binaries architecture. (cherry picked from commit 7253026)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 21, 2021
…-github-pr-comment-template * upstream/master: Check native environment before starting (elastic#25186) Change event.code and winlog.event_id type (elastic#25176) [Ingest Manager] Proxy processes/elastic-agent to stats (elastic#25193) Update mergify backporting to 7.x and 7.13 (elastic#25196) [Heartbeat]: ensure synthetics version co* [Heartbeat]: ensure synthetics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (elastic#24777) [Filebeat] Ensure Kibana audit `event.category` and `event.type` are still processed as strings. (elastic#25101) Update replace.asciidoc (elastic#25055) Fix nil panic when overwriting metadata (elastic#24741) [Filebeat] Add Malware Bazaar to Threat Intel Module (elastic#24570) Fix k8s svc selectors mapping (elastic#25169) [Ingest Manager] Make agent retry values for bootstraping configurable (elastic#25163) [Metricbeat] Remove elasticsearc.index.created from the SM code (elastic#25113)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 22, 2021
…ng-versions-stack * upstream/master: (28 commits) Add support for parsers in filestream input (elastic#24763) Skip flaky test TestFilestreamTruncate (elastic#25218) backport: Add 7.13 branch (elastic#25189) Update decode_json_fields.asciidoc (elastic#25056) [Elastic Agent] Fix status and inspect command to work inside running container (elastic#25204) Check native environment before starting (elastic#25186) Change event.code and winlog.event_id type (elastic#25176) [Ingest Manager] Proxy processes/elastic-agent to stats (elastic#25193) Update mergify backporting to 7.x and 7.13 (elastic#25196) [Heartbeat]: ensure synthetics version co* [Heartbeat]: ensure synthetics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (elastic#24777) [Filebeat] Ensure Kibana audit `event.category` and `event.type` are still processed as strings. (elastic#25101) Update replace.asciidoc (elastic#25055) Fix nil panic when overwriting metadata (elastic#24741) [Filebeat] Add Malware Bazaar to Threat Intel Module (elastic#24570) Fix k8s svc selectors mapping (elastic#25169) [Ingest Manager] Make agent retry values for bootstraping configurable (elastic#25163) [Metricbeat] Remove elasticsearc.index.created from the SM code (elastic#25113) [Ingest Manager] Keep http and logging config during enroll (elastic#25132) Refactor kubernetes autodiscover to avoid skipping short-living pods (elastic#24742) [libbeat] New decode xml wineventlog processor (elastic#25115) ...
urso
pushed a commit
that referenced
this pull request
Apr 24, 2021
urso
pushed a commit
that referenced
this pull request
Apr 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On Windows/Linux it is possible to run 32bit binaries. Now a check will be run to fail on startup if the architecture does not match the binaries architecture.
Why is it important?
Running Beats/Agent build for 32bits sometimes leads to problems on 64bit platforms. Some system metrics do have different sizing on 32 and 64bit architectures, which can trip up Agent/Beats wrongly interpreting the given data.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
The change contains an unit test.
Compile Beats or Agent with GOARCH=386 on a 64bit linux/windows and try to run it. The binary fails with exit code 1 + complains that you tried to run a 32bit binary on a 64bit system.
Related issues