[Ingest Manager] Make agent retry values for bootstraping configurable#25163
Merged
michalpristas merged 6 commits intoelastic:masterfrom Apr 20, 2021
Merged
[Ingest Manager] Make agent retry values for bootstraping configurable#25163michalpristas merged 6 commits intoelastic:masterfrom
michalpristas merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/agent (Team:Agent) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
ruflin
reviewed
Apr 20, 2021
Contributor
ruflin
left a comment
There was a problem hiding this comment.
One minor change request.
At one point we should discuss if these things should also be exposed through configs.
| defaultStateDirectory = "/usr/share/elastic-agent/state" // directory that will hold the state data | ||
| requestRetrySleepEnv = "KIBANA_REQUEST_RETRY_SLEEP" | ||
| maxRequestRetriesEnv = "KIBANA_REQUEST_RETRY_COUNT" | ||
| defaultRequestRetrySleep = "1" // sleep 1 sec between retries for HTTP requests |
Contributor
There was a problem hiding this comment.
Can we make this 1s instead and have time parsing? This makes it possible to pass in any time values if needed and makes it more explicity.
| KIBANA_FLEET_USERNAME - kibana username to enable Fleet [$KIBANA_USERNAME] | ||
| KIBANA_FLEET_PASSWORD - kibana password to enable Fleet [$KIBANA_PASSWORD] | ||
| KIBANA_FLEET_CA - path to certificate authority to use with communicate with Kibana [$KIBANA_CA] | ||
| KIBANA_REQUEST_RETRY_SLEEP - specifies number of seconds of sleep taken when agent performs a request to kibana [default 1] |
Contributor
There was a problem hiding this comment.
See above
Suggested change
| KIBANA_REQUEST_RETRY_SLEEP - specifies number of seconds of sleep taken when agent performs a request to kibana [default 1] | |
| KIBANA_REQUEST_RETRY_SLEEP - specifies number of seconds of sleep taken when agent performs a request to kibana [default 1s] |
simitt
reviewed
Apr 20, 2021
simitt
approved these changes
Apr 20, 2021
Contributor
simitt
left a comment
There was a problem hiding this comment.
Havent't tested yet, but LGTM
|
In general LGTM. Should we consider exponential backoff (see: libbeat/common/backoff)? |
Contributor
Can this be done in a follow up PR? |
Contributor
Author
|
i think blake did not go with exponential because we're just waiting for kibana to be online. we want result as soon as possible and we're not spamming kibana with request as it does not perform any work in this case. |
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Apr 20, 2021
elastic#25163) [Ingest Manager] Make agent retry values for bootstraping configurable (elastic#25163)
6 tasks
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 21, 2021
…-github-pr-comment-template * upstream/master: Check native environment before starting (elastic#25186) Change event.code and winlog.event_id type (elastic#25176) [Ingest Manager] Proxy processes/elastic-agent to stats (elastic#25193) Update mergify backporting to 7.x and 7.13 (elastic#25196) [Heartbeat]: ensure synthetics version co* [Heartbeat]: ensure synthetics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (elastic#24777) [Filebeat] Ensure Kibana audit `event.category` and `event.type` are still processed as strings. (elastic#25101) Update replace.asciidoc (elastic#25055) Fix nil panic when overwriting metadata (elastic#24741) [Filebeat] Add Malware Bazaar to Threat Intel Module (elastic#24570) Fix k8s svc selectors mapping (elastic#25169) [Ingest Manager] Make agent retry values for bootstraping configurable (elastic#25163) [Metricbeat] Remove elasticsearc.index.created from the SM code (elastic#25113)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 22, 2021
…ng-versions-stack * upstream/master: (28 commits) Add support for parsers in filestream input (elastic#24763) Skip flaky test TestFilestreamTruncate (elastic#25218) backport: Add 7.13 branch (elastic#25189) Update decode_json_fields.asciidoc (elastic#25056) [Elastic Agent] Fix status and inspect command to work inside running container (elastic#25204) Check native environment before starting (elastic#25186) Change event.code and winlog.event_id type (elastic#25176) [Ingest Manager] Proxy processes/elastic-agent to stats (elastic#25193) Update mergify backporting to 7.x and 7.13 (elastic#25196) [Heartbeat]: ensure synthetics version co* [Heartbeat]: ensure synthetics version compatability for suites * address review and fix notice * fix lowercase struct * fix version conflict and rebase * update go.* stuff to master * fix notice.txt * move validate inside sourcempatability for suites (elastic#24777) [Filebeat] Ensure Kibana audit `event.category` and `event.type` are still processed as strings. (elastic#25101) Update replace.asciidoc (elastic#25055) Fix nil panic when overwriting metadata (elastic#24741) [Filebeat] Add Malware Bazaar to Threat Intel Module (elastic#24570) Fix k8s svc selectors mapping (elastic#25169) [Ingest Manager] Make agent retry values for bootstraping configurable (elastic#25163) [Metricbeat] Remove elasticsearc.index.created from the SM code (elastic#25113) [Ingest Manager] Keep http and logging config during enroll (elastic#25132) Refactor kubernetes autodiscover to avoid skipping short-living pods (elastic#24742) [libbeat] New decode xml wineventlog processor (elastic#25115) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an option to configure values used in container command for GET/POST request to kibana.
Why is it important?
#25063
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.cc @simitt