Cherry-pick #25051 to 7.12: Update go-structform to 0.0.8#25179
Merged
urso merged 1 commit intoelastic:7.12from Apr 21, 2021
Merged
Cherry-pick #25051 to 7.12: Update go-structform to 0.0.8#25179urso merged 1 commit intoelastic:7.12from
urso merged 1 commit intoelastic:7.12from
Conversation
(cherry picked from commit fb1eb8d)
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Author
|
/test |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…stic#25179) (cherry picked from commit cb0ccf9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #25051 to 7.12 branch. Original message:
What does this PR do?
Update go structform and configure json encoding to encode NaN and Inf
as
nullvalues.Why is it important?
The json encoder is used by all outputs and debug logging. NaN and Inf
are undefined in the JSON standart. By not being able to encode or even
display those values in the log output, we have data loss without being
able to identify the actual event.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.