Merged
Conversation
|
This pull request doesn't have a |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
fearful-symmetry
approved these changes
Apr 14, 2021
added 4 commits
April 14, 2021 20:15
Update go structform and configure json encoding to encode NaN and Inf as `null` values. The json encoder is used by all outputs and debug logging. NaN and Inf are undefined in the JSON standart. By not being able to encode or even display those values in the log output, we have data loss without being able to identify the actual event.
204a297 to
047ce58
Compare
mergify bot
pushed a commit
that referenced
this pull request
Apr 14, 2021
(cherry picked from commit fb1eb8d)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 15, 2021
* upstream/master: packer cache support for the 7.x and 7.latestMinor branches (elastic#25091) Remove EventFetcher and EventsFetcher interface (elastic#25093) Update go-structform to 0.0.8 (elastic#25051) Update copy_fields.asciidoc (elastic#25053) [elastic-agent] ensure container is backwards compatible (elastic#25092) Add --fleet-server-service-token. Rename --fleet-server to --fleet-server-es. (elastic#25083) Add cgroup.cpuacct percentages (elastic#25057) Add tests for truncated and symlinked files in filestream input (elastic#24425) Fix panic when Hearbeat monitor initialization fails twice (elastic#25073) [Filebeat][httpjson] Change append transform to initiate new fields as a slice (elastic#25074) Osquerybeat: Result values type translation (elastic#25012) Update Osquerybeat spec to get it downloading from the correct artifactory path (elastic#25076) Fix changelog (elastic#25079) Strip Azure EventHub connection string in debug logs (elastic#25066) Change googlecloud to gcp in field names (elastic#25038) Bump stack version to 7.12.0 for testing (elastic#24957) packer-cache: cache the existing docker images on ARM and some more (elastic#25068) Disable logstash TestFetch flaky test (elastic#25044)
urso
pushed a commit
that referenced
this pull request
Apr 15, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 20, 2021
(cherry picked from commit fb1eb8d) # Conflicts: # go.sum
3 tasks
urso
pushed a commit
to urso/beats
that referenced
this pull request
Apr 20, 2021
(cherry picked from commit fb1eb8d)
urso
pushed a commit
that referenced
this pull request
Apr 21, 2021
(cherry picked from commit fb1eb8d)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…stic#25179) (cherry picked from commit cb0ccf9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update go structform and configure json encoding to encode NaN and Inf
as
nullvalues.Why is it important?
The json encoder is used by all outputs and debug logging. NaN and Inf
are undefined in the JSON standart. By not being able to encode or even
display those values in the log output, we have data loss without being
able to identify the actual event.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.