Empty configuration options generate <no value> string for azure-eventhub input#24156
Merged
narph merged 2 commits intoelastic:masterfrom Feb 23, 2021
Merged
Empty configuration options generate <no value> string for azure-eventhub input#24156narph merged 2 commits intoelastic:masterfrom
<no value> string for azure-eventhub input#24156narph merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Contributor
|
do we need to make (some of) these changes in the package as well? |
Contributor
Author
different behavior is found there but we should add the same check for the params as well, will follow up with a PR |
narph
added a commit
to narph/beats
that referenced
this pull request
Feb 23, 2021
…enthub input (elastic#24156) * work on no value * changelog (cherry picked from commit 916d4e0)
narph
added a commit
to narph/beats
that referenced
this pull request
Feb 23, 2021
…enthub input (elastic#24156) * work on no value * changelog (cherry picked from commit 916d4e0)
narph
added a commit
to narph/beats
that referenced
this pull request
Feb 23, 2021
…enthub input (elastic#24156) * work on no value * changelog (cherry picked from commit 916d4e0)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Feb 23, 2021
…-arm * upstream/master: (24 commits) Add example input autodsicover config (elastic#24157) Empty configuration options generate `<no value>` string for azure-eventhub input (elastic#24156) Remove OSS reference for kibana and elasticsearch (elastic#24164) Skip flaky TestActions on MacOSx (elastic#23966) [Filebeat][AWS] Fix vpcflow pipeline exception: Cannot invoke "Object.getClass()" because "receiver" is null (elastic#24167) [Elastic Agent] Fix docker entrypoint for elastic-agent. (elastic#24155) [PACKAGING] Push docker images with the architecture in the version (elastic#24121) [Agent] Add agent standalone manifests for system module & Pod's log collection (elastic#23938) indicator type url is in upper case (elastic#24152) [Filebeat] Document netflow internal_networks and set default (elastic#24110) [Filebeat] Adding fixes to the TI module (elastic#24133) [Enhancement] Add RotateOnStartup feature flag for file output (elastic#19347) [Ingest Manager] Fix: Successfully installed and enrolled agent running standalone (elastic#24128) Set Elastic licence type for APM server Beats update job (elastic#24122) Add logrotation section on Running Filebeat on k8s (elastic#24120) [CI] Run if manual UI (elastic#24116) [CI] enable x-pack/heartbeat in the CI (elastic#23873) chore: comment out the E2E (elastic#24109) chore: add-backport-next (elastic#24098) Adjust the position of the architecture name in Dockerlogbeat tarball (elastic#24095) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Feb 23, 2021
…dows-7 * upstream/master: [CI] Add ARM packaging (elastic#24041) Add example input autodsicover config (elastic#24157) Empty configuration options generate `<no value>` string for azure-eventhub input (elastic#24156)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
makes sure to provide empty string values when input configuration is validated
Why is it important?
<no value>string is sent instead of empty value and sometimes passes required validationChecklist