Skip to content

Cherry-pick #24156 to 7.x: Empty configuration options generate <no value> string for azure-eventhub input#24181

Merged
narph merged 2 commits intoelastic:7.xfrom
narph:backport_24156_7.x
Mar 10, 2021
Merged

Cherry-pick #24156 to 7.x: Empty configuration options generate <no value> string for azure-eventhub input#24181
narph merged 2 commits intoelastic:7.xfrom
narph:backport_24156_7.x

Conversation

@narph
Copy link
Copy Markdown
Contributor

@narph narph commented Feb 23, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #24156 to 7.x branch. Original message:

What does this PR do?

makes sure to provide empty string values when input configuration is validated

Why is it important?

<no value> string is sent instead of empty value and sometimes passes required validation

Checklist

@narph
Empty configuration options generate <no value> string for azure-ev…
ebf9c75 
…enthub input (elastic#24156)

* work on no value

* changelog

(cherry picked from commit 916d4e0)
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Feb 23, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 23, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 23, 2021
@botelastic
Copy link
Copy Markdown

botelastic bot commented Feb 23, 2021

This pull request doesn't have a Team:<team> label.

@narph narph self-assigned this Feb 23, 2021
@narph narph requested a review from adriansr February 23, 2021 12:03
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 23, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by user Mariana Dima

  • Start Time: 2021-02-23T15:24:56.965+0000

  • Duration: 56 min 48 sec

  • Commit: dfdde7f

Test stats 🧪

Test Results
Failed 0
Passed 6814
Skipped 1153
Total 7967

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6814
Skipped 1153
Total 7967

@narph narph merged commit bea9a9b into elastic:7.x Mar 10, 2021
@narph narph deleted the backport_24156_7.x branch March 10, 2021 12:46
@zube zube bot removed the [zube]: Done label Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

@adriansr adriansr Awaiting requested review from adriansr

Assignees

@narph narph

Labels

backport Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@narph @elasticmachine @jsoriano