Fix: bad substitution of API key#24036
Merged
mtojek merged 2 commits intoelastic:masterfrom Feb 15, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/agent (Team:Agent) |
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Log outputExpand to view the last 100 lines of log output
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
1 task
simitt
approved these changes
Feb 15, 2021
| - Increase checkin grace period to 30 seconds {pull}23568[23568] | ||
| - Fix libbeat from reporting back degraded on config update {pull}23537[23537] | ||
| - Fix issues with dynamic inputs and conditions {pull}23886[23886] | ||
| - Fix bad substitution of API key. {pull}24036[24036] |
Contributor
There was a problem hiding this comment.
Is this required? I assume the fix goes into the same version (7.12) as the changes that broke the setup.
Contributor
Author
There was a problem hiding this comment.
I don't have a strong opinion about it. This is a change (bugfix) hence the CHANGELOG entry. I will backport it to 7.x once this is merged.
Contributor
There was a problem hiding this comment.
Maybe I am not up-to-date with how this works in the beats repo, but since Changelog entries are usually user facing, I am used to only include bugfixes that are user facing (which is not the case if introduced & fixed in the same version). Up to you though whether or not to keep it.
Contributor
Author
|
/packaging |
Contributor
Author
|
Errors unrelated. |
2 tasks
mtojek
added a commit
to mtojek/beats
that referenced
this pull request
Feb 15, 2021
* Fix: bad substitution of API key * Update changelog (cherry picked from commit 8ea9a95)
mtojek
added a commit
that referenced
this pull request
Feb 16, 2021
v1v
added a commit
to v1v/beats
that referenced
this pull request
Feb 16, 2021
…-arm * upstream/master: [Metricbeat][Kubernetes] Extend state_node with more conditions (elastic#23905) [CI] googleStorageUploadExt step (elastic#24048) Check fields are documented for aws metricsets (elastic#23887) Update go-concert to 0.1.0 (elastic#23770) [Libbeat][New Processor] XML Decode (elastic#23678) Fix: bad substitution of API key (elastic#24036) [Filebeat] Add Pensando DFW Module (elastic#21063) [Filebeat] Check if processor is supported by ES version (elastic#23763) Syslog system tests: be more forgiving (elastic#24021)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the bad substitution (typo), spotted in https://beats-ci.elastic.co/job/Ingest-manager/job/elastic-package/job/PR-246/45/artifact/build/elastic-stack-dump/stack/logs/elastic-agent.log .
Why is it important?
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues