Skip to content

Cherry-pick #24036 to 7.x: Fix: bad substitution of API key#24047

Merged
mtojek merged 1 commit intoelastic:7.xfrom
mtojek:backport_24036_7.x
Feb 16, 2021
Merged

Cherry-pick #24036 to 7.x: Fix: bad substitution of API key#24047
mtojek merged 1 commit intoelastic:7.xfrom
mtojek:backport_24036_7.x

Conversation

@mtojek
Copy link
Copy Markdown
Contributor

@mtojek mtojek commented Feb 15, 2021

Cherry-pick of PR #24036 to 7.x branch. Original message:

What does this PR do?

This PR fixes the bad substitution (typo), spotted in https://beats-ci.elastic.co/job/Ingest-manager/job/elastic-package/job/PR-246/45/artifact/build/elastic-stack-dump/stack/logs/elastic-agent.log .

Why is it important?

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Create new custom policy in the Kibana UI.
  2. Start new Docker container with Elastic Agent, don't provide the enrollment token.

Related issues

* Fix: bad substitution of API key

* Update changelog

(cherry picked from commit 8ea9a95)
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 15, 2021
@mtojek mtojek requested a review from michalpristas February 15, 2021 18:06
@mtojek mtojek self-assigned this Feb 15, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: mtojek commented: /test

  • Start Time: 2021-02-15T21:44:47.535+0000

  • Duration: 169 min 29 sec

  • Commit: 30e4b7a

Test stats 🧪

Test Results
Failed 0
Passed 46391
Skipped 4799
Total 51190

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 2

Expand to view the steps failures

heartbeat-windows-windows-2019 - Install Go/Mage/Python 1.15.8
  • Took 0 min 1 sec . View more details on here
  • Description: .ci/scripts/install-tools.bat
journalbeat-packaging-linux - Install Go/Mage/Python/Docker/Terraform 1.15.8
  • Took 0 min 6 sec . View more details on here
  • Description: .ci/scripts/install-tools.sh

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 46391
Skipped 4799
Total 51190

@mtojek
Copy link
Copy Markdown
Contributor Author

mtojek commented Feb 15, 2021

Errors unrelated.

@mtojek mtojek requested a review from ycombinator February 15, 2021 20:03
@mtojek
Copy link
Copy Markdown
Contributor Author

mtojek commented Feb 15, 2021

/test

Copy link
Copy Markdown
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mtojek mtojek merged commit a6d108f into elastic:7.x Feb 16, 2021
@zube zube bot removed the [zube]: Done label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Elastic-Agent Label for the Agent team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants