[Filebeat] Convert o365 client.port to number#22939
Merged
andrewkroh merged 2 commits intoelastic:masterfrom Dec 10, 2020
Merged
[Filebeat] Convert o365 client.port to number#22939andrewkroh merged 2 commits intoelastic:masterfrom
andrewkroh merged 2 commits intoelastic:masterfrom
Conversation
Convert the client.port and source.port values to numbers in the event to match the data type used in the ES mapping (and ECS).
e502b0c to
f1fba4c
Compare
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
leehinman
reviewed
Dec 9, 2020
leehinman
approved these changes
Dec 9, 2020
2 tasks
andrewkroh
added a commit
to elastic/integrations
that referenced
this pull request
Dec 15, 2020
* Add system test for Office 365 audiit This changes mappings for a few fields to boolean. And it changes client.port and source.port to be numbers in the JSON source to match their mappings. The remaining issues will be handled by elastic/elastic-package#193. This is the test output after fixing the booleans. FAILURE DETAILS: o365/audit : [0] parsing field value failed: field "client.port"''s Go type, string, does not match the expected field type: long [1] parsing field value failed: field "event.code"''s Go type, float64, does not match the expected field type: keyword [2] parsing field value failed: field "o365.audit.ActorYammerUserId"''s Go type, float64, does not match the expected field type: keyword [3] parsing field value failed: field "o365.audit.AzureActiveDirectoryEventType"''s Go type, float64, does not match the expected field type: keyword [4] parsing field value failed: field "o365.audit.InternalLogonType"''s Go type, float64, does not match the expected field type: keyword [5] parsing field value failed: field "o365.audit.LogonType"''s Go type, float64, does not match the expected field type: keyword [6] parsing field value failed: field "o365.audit.RecordType"''s Go type, float64, does not match the expected field type: keyword [7] parsing field value failed: field "o365.audit.UserType"''s Go type, float64, does not match the expected field type: keyword [8] parsing field value failed: field "o365.audit.Version"''s Go type, float64, does not match the expected field type: keyword [9] parsing field value failed: field "o365.audit.YammerNetworkId"''s Go type, float64, does not match the expected field type: keyword [10] parsing field value failed: field "source.port"''s Go type, string, does not match the expected field type: long --- Test results for package: o365 - END --- * Configure numeric_keyword_fields * Sync pipeline JS to get elastic/beats#22939
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Convert the
client.portandsource.portvalues to numbers in the event to matchthe data type used in the ES mapping (and ECS).
Why is it important?
To prevent mapping conflicts it's better to convert the fields to numbers in the pipeline.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.