Skip to content

Add system test for Office 365 audit#449

Merged
andrewkroh merged 4 commits intoelastic:masterfrom
andrewkroh:o365-audit-system-test
Dec 15, 2020
Merged

Add system test for Office 365 audit#449
andrewkroh merged 4 commits intoelastic:masterfrom
andrewkroh:o365-audit-system-test

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Dec 5, 2020

What does this PR do?

This adds a system test for Office 365 audit.

This changes mappings for a few fields to boolean. And it changes client.port and source.port to be numbers in the
JSON source to match their mappings. The remaining issues will be handled by elastic/elastic-package#193.
This is the test output after fixing the booleans.

FAILURE DETAILS:

o365/audit :
[0] parsing field value failed: field "client.port"''s Go type, string, does not match the expected field type: long
[1] parsing field value failed: field "event.code"''s Go type, float64, does not match the expected field type: keyword
[2] parsing field value failed: field "o365.audit.ActorYammerUserId"''s Go type, float64, does not match the expected field type: keyword
[3] parsing field value failed: field "o365.audit.AzureActiveDirectoryEventType"''s Go type, float64, does not match the expected field type: keyword
[4] parsing field value failed: field "o365.audit.InternalLogonType"''s Go type, float64, does not match the expected field type: keyword
[5] parsing field value failed: field "o365.audit.LogonType"''s Go type, float64, does not match the expected field type: keyword
[6] parsing field value failed: field "o365.audit.RecordType"''s Go type, float64, does not match the expected field type: keyword
[7] parsing field value failed: field "o365.audit.UserType"''s Go type, float64, does not match the expected field type: keyword
[8] parsing field value failed: field "o365.audit.Version"''s Go type, float64, does not match the expected field type: keyword
[9] parsing field value failed: field "o365.audit.YammerNetworkId"''s Go type, float64, does not match the expected field type: keyword
[10] parsing field value failed: field "source.port"''s Go type, string, does not match the expected field type: long
--- Test results for package: o365 - END   ---

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Related issues

@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Dec 5, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #449 updated

  • Start Time: 2020-12-14T22:26:54.198+0000

  • Duration: 26 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 143
Skipped 0
Total 143

This changes mappings for a few fields to boolean. And it changes client.port and source.port to be numbers in the
JSON source to match their mappings. The remaining issues will be handled by elastic/elastic-package#193.
This is the test output after fixing the booleans.

    FAILURE DETAILS:

    o365/audit :
    [0] parsing field value failed: field "client.port"''s Go type, string, does not match the expected field type: long
    [1] parsing field value failed: field "event.code"''s Go type, float64, does not match the expected field type: keyword
    [2] parsing field value failed: field "o365.audit.ActorYammerUserId"''s Go type, float64, does not match the expected field type: keyword
    [3] parsing field value failed: field "o365.audit.AzureActiveDirectoryEventType"''s Go type, float64, does not match the expected field type: keyword
    [4] parsing field value failed: field "o365.audit.InternalLogonType"''s Go type, float64, does not match the expected field type: keyword
    [5] parsing field value failed: field "o365.audit.LogonType"''s Go type, float64, does not match the expected field type: keyword
    [6] parsing field value failed: field "o365.audit.RecordType"''s Go type, float64, does not match the expected field type: keyword
    [7] parsing field value failed: field "o365.audit.UserType"''s Go type, float64, does not match the expected field type: keyword
    [8] parsing field value failed: field "o365.audit.Version"''s Go type, float64, does not match the expected field type: keyword
    [9] parsing field value failed: field "o365.audit.YammerNetworkId"''s Go type, float64, does not match the expected field type: keyword
    [10] parsing field value failed: field "source.port"''s Go type, string, does not match the expected field type: long
    --- Test results for package: o365 - END   ---
@andrewkroh andrewkroh merged commit 7dad36a into elastic:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants