Skip to content

[Elastic Agent] Fix TestEQL on Windows 32-bit#22349

Merged
blakerouse merged 1 commit intoelastic:masterfrom
blakerouse:fix-test-eql-windows-32bit
Nov 2, 2020
Merged

[Elastic Agent] Fix TestEQL on Windows 32-bit#22349
blakerouse merged 1 commit intoelastic:masterfrom
blakerouse:fix-test-eql-windows-32bit

Conversation

@blakerouse
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes TestEql number test to be an integer less than 32-bit so it doesn't overflow and cause the test to fail.

Why is it important?

So tests can pass on 32-bit systems.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 2, 2020
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 6
Total 1390

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22349 opened]

  • Start Time: 2020-11-02T14:14:43.074+0000

  • Duration: 26 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 6
Total 1390

@blakerouse blakerouse merged commit 0626c2a into elastic:master Nov 2, 2020
@blakerouse blakerouse deleted the fix-test-eql-windows-32bit branch November 2, 2020 14:43
blakerouse added a commit to blakerouse/beats that referenced this pull request Nov 2, 2020
blakerouse added a commit that referenced this pull request Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[x-pack/elastic-agent][windows-7-32] got some failed tests for TestEql

3 participants