Cherry-pick #22349 to 7.x: [Elastic Agent] Fix TestEQL on Windows 32-bit#22350
Merged
blakerouse merged 1 commit intoelastic:7.xfrom Nov 16, 2020
Merged
Cherry-pick #22349 to 7.x: [Elastic Agent] Fix TestEQL on Windows 32-bit#22350blakerouse merged 1 commit intoelastic:7.xfrom
blakerouse merged 1 commit intoelastic:7.xfrom
Conversation
(cherry picked from commit 0626c2a)
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Contributor
Author
|
jenkins run tests |
1 similar comment
Contributor
Author
|
jenkins run tests |
michalpristas
approved these changes
Nov 16, 2020
Contributor
michalpristas
left a comment
There was a problem hiding this comment.
Backport looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #22349 to 7.x branch. Original message:
What does this PR do?
Fixes TestEql
numbertest to be an integer less than 32-bit so it doesn't overflow and cause the test to fail.Why is it important?
So tests can pass on 32-bit systems.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues