[Ingest Manager] Syncing unpacked files#21706
Merged
michalpristas merged 1 commit intoelastic:masterfrom Oct 13, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Contributor
Author
|
/packaging |
Contributor
Author
|
/package |
1 similar comment
Contributor
Author
|
/package |
blakerouse
approved these changes
Oct 12, 2020
Contributor
blakerouse
left a comment
There was a problem hiding this comment.
Interesting discovery. Change looks good, hope this fixes the e2e test!
6 tasks
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 13, 2020
* upstream/master: (127 commits) Update obs app links (elastic#21682) fix: update fleet test suite name (elastic#21738) Remove dot from file.extension value in Auditbeat FIM (elastic#21644) Fix leaks with metadata processors (elastic#16349) Add istiod metricset (elastic#21519) [Ingest Manager] Change Sync/Close call order (elastic#21735) [Ingest Manager] Syncing unpacked files (elastic#21706) Fix concurrent map read and write in socket dataset (elastic#21690) Fix conditional coding to remove seccomp info from Winlogbeat (elastic#21652) [Elastic Agent] Fix issue where inputs without processors defined would panic (elastic#21628) Add configuration of filestream input (elastic#21565) libbeat/logp: introduce Logger.WithOptions (elastic#21671) Make o365audit input cancellable (elastic#21647) fix: remove extra curly brace in script (elastic#21692) [Winlogbeat] Remove brittle configuration validation from wineventlog (elastic#21593) Fix function that parses from/to/contact headers (elastic#21672) [CI] Support Windows-2016 in pipeline 2.0 (elastic#21337) Skip publisher flaky tests (elastic#21657) backport: add 7.10 branch (elastic#21635) [CI: Packaging] fix: push ubi8 images too (elastic#21621) ...
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Oct 14, 2020
[Ingest Manager] Syncing unpacked files (elastic#21706)
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Oct 14, 2020
[Ingest Manager] Syncing unpacked files (elastic#21706)
This was referenced Oct 14, 2020
michalpristas
added a commit
that referenced
this pull request
Oct 14, 2020
* [Ingest Manager] Syncing unpacked files (#21706) [Ingest Manager] Syncing unpacked files (#21706) * [Ingest Manager] Change Sync/Close call order (#21735) [Ingest Manager] Change Sync/Close call order (#21735) * [Ingest Manager] Agent atomic installer (#21745) [Ingest Manager] Agent atomic installer (#21745)
michalpristas
added a commit
that referenced
this pull request
Oct 14, 2020
* [Ingest Manager] Syncing unpacked files (#21706) [Ingest Manager] Syncing unpacked files (#21706) * [Ingest Manager] Change Sync/Close call order (#21735) [Ingest Manager] Change Sync/Close call order (#21735) * [Ingest Manager] Agent atomic installer (#21745) [Ingest Manager] Agent atomic installer (#21745)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a sync call after files are unpacked from archives to disk. This seems to help with issues we've seen in tests where agent reported
text file busywhen executing beat. On second try it was able to execute binary.Why is it important?
Gets rid of errors when executing beats and makes spinning beats up faster avoiding unnecessary retries.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.