Skip to content

Cherry-pick #21745 to 7.x: Agent atomic installer#21779

Merged
michalpristas merged 4 commits intoelastic:7.xfrom
michalpristas:backport_21745_7.x
Oct 14, 2020
Merged

Cherry-pick #21745 to 7.x: Agent atomic installer#21779
michalpristas merged 4 commits intoelastic:7.xfrom
michalpristas:backport_21745_7.x

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Oct 14, 2020 •
edited
Loading

Cherry-pick of PR #21745 to 7.x branch. Original message:

Cherry-pick also dependencies: #21735 and #21706

What does this PR do?

This PR makes unpacking an "atomic" operation by unpacking to temporary location and then moving it to the correct place, this should solve some rare issues which manifests when agent got killed during installation of beats and results in half-unpacked archive to be understood as correct installation

I tested this change on darwin/linux/windows and using local e2e test suite.

Fixes: #21718

Why is it important?

Makes agent more reliable

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas self-assigned this Oct 14, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 14, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 14, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 14, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21779 updated]

  • Start Time: 2020-10-14T06:59:02.672+0000

  • Duration: 39 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 1394
Skipped 4
Total 1398

blakerouse
blakerouse approved these changes Oct 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit 6f284fb into elastic:7.x Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels

backport bug Ingest Management:beta2 Group issues for ingest management beta2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michalpristas @elasticmachine @blakerouse @ph