Skip to content

Docker build resiliance with a retry#21587

Merged
v1v merged 1 commit intoelastic:masterfrom
v1v:feature/build-docker-images-before-running-them
Oct 8, 2020
Merged

Docker build resiliance with a retry#21587
v1v merged 1 commit intoelastic:masterfrom
v1v:feature/build-docker-images-before-running-them

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Oct 6, 2020 •
edited
Loading

What does this PR do?

Retry to build docker images when something bad happened.

We could potentially include a retry step in the CI but it might add some overhead, another approach could be creating a specific mage goal to run the docker-compose build rather than just using mage pythonIntegTest for everything.

Why is it important?

Sometimes some third party resources are not accessible temporarily. For instance

[2020-10-06T10:53:15.087Z] + mage pythonIntegTest
[2020-10-06T10:54:11.398Z] Generated fields.yml for metricbeat to /var/lib/jenkins/workspace/Beats_beats_master/src/github.com/elastic/beats/metricbeat/fields.yml
[2020-10-06T10:54:26.345Z] >> Building docker images
[2020-10-06T10:54:26.345Z] Building beat
[2020-10-06T10:54:58.493Z] Service 'beat' failed to build: The command '/bin/sh -c cd /usr/lib   && curl -sLo instantclient-basic-linux.zip https://download.oracle.com/otn_software/linux/instantclient/19600/instantclient-basic-linux.x64-19.6.0.0.0dbru.zip   && unzip instantclient-basic-linux.zip   && rm instantclient-basic-linux.zip' returned a non-zero code: 56
[2020-10-06T10:54:58.493Z] Error: running "docker-compose -p metricbeat_8_0_0_0dd24289fa-snapshot build --force-rm --pull" failed with exit code 1

Related issues

Caused by #21563

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 6, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 6, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21587 opened]

  • Start Time: 2020-10-06T16:51:01.516+0000

  • Duration: 81 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 16290
Skipped 1343
Total 17633

@v1v v1v added Team:Automation Label for the Observability productivity team Team:Integrations Label for the Integrations team labels Oct 6, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 6, 2020
@v1v v1v self-assigned this Oct 6, 2020
@v1v v1v requested review from a team, andrewkroh, jsoriano and kvch October 6, 2020 19:11
@v1v v1v added the automation label Oct 6, 2020
@v1v v1v marked this pull request as ready for review October 7, 2020 08:13
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 7, 2020

Pinging @elastic/integrations (Team:Integrations)

@v1v v1v merged commit 1f29969 into elastic:master Oct 8, 2020
@v1v v1v deleted the feature/build-docker-images-before-running-them branch October 8, 2020 09:57
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
Docker build resiliance with a retry (elastic#21587)
f5b1c37
@v1v v1v mentioned this pull request Oct 8, 2020
Merged
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
Docker build resiliance with a retry (elastic#21587)
f673c60
@v1v v1v mentioned this pull request Oct 8, 2020
Merged
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
Docker build resiliance with a retry (elastic#21587)
939f12c
@v1v v1v mentioned this pull request Oct 8, 2020
Merged
v1v added a commit that referenced this pull request Oct 8, 2020
@v1v
Docker build resiliance with a retry (#21587) (#21678)
3250fe0
v1v added a commit that referenced this pull request Oct 8, 2020
@v1v
Docker build resiliance with a retry (#21587) (#21679)
57ef955
v1v added a commit that referenced this pull request Oct 8, 2020
@v1v
Docker build resiliance with a retry (#21587) (#21680)
8771a3f
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/2.0-skip-…
36ed51a 
…ci-build-label-support

* upstream/master: (60 commits)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  Docker build resiliance with a retry (elastic#21587)
  Fix flaky FSWatch/FSScanner tests (elastic#21625)
  chore: add versions 7.1x (elastic#21670)
  [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599)
  Fix cyberark/corepas pipeline (elastic#21643)
  Add openstack ssl provider in add_cloud_metadata (elastic#21590)
  Add fips_enabled into all aws filesets (elastic#21626)
  [Filebeat S3] Change log.file.path to be nested object (elastic#21624)
  [CI] Change notification channel (elastic#21559)
  Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501)
  [E2E Tests] fix: set versions ony for PRs (elastic#21608)
  Fix badger build in 386 (elastic#21613)
  docs: Update timestamp.asciidoc (elastic#20395)
  Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457)
  [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498)
  [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585)
  [Ingest Manager] Use new form of fleet API paths (elastic#21478)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2…
b3b7cb1 
…012-2.0

* upstream/master: (110 commits)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  Docker build resiliance with a retry (elastic#21587)
  Fix flaky FSWatch/FSScanner tests (elastic#21625)
  chore: add versions 7.1x (elastic#21670)
  [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599)
  Fix cyberark/corepas pipeline (elastic#21643)
  Add openstack ssl provider in add_cloud_metadata (elastic#21590)
  Add fips_enabled into all aws filesets (elastic#21626)
  [Filebeat S3] Change log.file.path to be nested object (elastic#21624)
  [CI] Change notification channel (elastic#21559)
  Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501)
  [E2E Tests] fix: set versions ony for PRs (elastic#21608)
  Fix badger build in 386 (elastic#21613)
  docs: Update timestamp.asciidoc (elastic#20395)
  Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457)
  [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498)
  [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585)
  [Ingest Manager] Use new form of fleet API paths (elastic#21478)
  ...
@v1v v1v mentioned this pull request Oct 21, 2020
Closed
@zube zube bot removed the [zube]: Done label Jan 6, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@v1v
Docker build resiliance with a retry (elastic#21587) (elastic#21680)
374ee52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cachedout cachedout cachedout approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

@jsoriano jsoriano Awaiting requested review from jsoriano

+2 more reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

@kvch kvch kvch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v1v v1v

Labels

automation Team:Automation Label for the Observability productivity team Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@v1v @elasticmachine @cachedout @mdelapenya @kvch @kuisathaverat @andresrc