Skip to content

Update timestamp.asciidoc#20395

Merged
bmorelli25 merged 2 commits intoelastic:masterfrom
Bernhard-Fluehmann:patch-2
Oct 6, 2020
Merged

Update timestamp.asciidoc#20395
bmorelli25 merged 2 commits intoelastic:masterfrom
Bernhard-Fluehmann:patch-2

Conversation

@Bernhard-Fluehmann
Copy link
Copy Markdown
Contributor

@Bernhard-Fluehmann Bernhard-Fluehmann commented Aug 3, 2020

Add example for better understanding

What does this PR do?

Why is it important?

Checklist

  • [x ] My code follows the style guidelines of this project
  • [ x] I have commented my code, particularly in hard-to-understand areas

@Bernhard-Fluehmann
Update timestamp.asciidoc
bfe55f2 
Add example for better understanding
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 3, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 3, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 3, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 3, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20395 updated]

  • Start Time: 2020-09-29T20:25:10.807+0000

  • Duration: 24 min 58 sec

@andresrc andresrc added docs Team:Services (Deprecated) Label for the former Integrations-Services team labels Aug 4, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 4, 2020

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 4, 2020
@andresrc andresrc requested a review from a team August 4, 2020 08:08
dedemorton
dedemorton approved these changes Aug 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delayed response. GitHub notification got lost...

@botelastic
Copy link
Copy Markdown

botelastic bot commented Sep 12, 2020

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Sep 12, 2020
@bmorelli25
Copy link
Copy Markdown
Member

bmorelli25 commented Sep 21, 2020

@Bernhard-Fluehmann, can you sign our contributor agreement so we can get this merged? Thanks!

@botelastic botelastic bot removed the Stalled label Sep 21, 2020
@Bernhard-Fluehmann
Copy link
Copy Markdown
Contributor Author

Bernhard-Fluehmann commented Sep 28, 2020

@bmorelli25 Thank you for your response. As far as I know I already have a signed CLA. Please let me know if there are an issues with it. Regards

@bmorelli25
Copy link
Copy Markdown
Member

bmorelli25 commented Sep 29, 2020

@elasticmachine retest please

@bmorelli25
Copy link
Copy Markdown
Member

bmorelli25 commented Sep 29, 2020

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
docs: small change
d95268f 
Adding this small change to force a retest
@bmorelli25
Copy link
Copy Markdown
Member

bmorelli25 commented Sep 29, 2020

I added a small commit to force a recheck of the CLA; we're green! I'll get this merged and backported once all tests are green.

@bmorelli25
Copy link
Copy Markdown
Member

bmorelli25 commented Sep 29, 2020

@elasticmachine, run elasticsearch-ci/docs

@Bernhard-Fluehmann
Copy link
Copy Markdown
Contributor Author

Bernhard-Fluehmann commented Sep 30, 2020

Thanks

@bmorelli25 bmorelli25 merged commit fac0347 into elastic:master Oct 6, 2020
bmorelli25 pushed a commit to bmorelli25/beats that referenced this pull request Oct 6, 2020
@Bernhard-Fluehmann @bmorelli25
docs: Update timestamp.asciidoc (elastic#20395)
c671066
@bmorelli25 bmorelli25 mentioned this pull request Oct 6, 2020
Merged
bmorelli25 pushed a commit to bmorelli25/beats that referenced this pull request Oct 6, 2020
@Bernhard-Fluehmann @bmorelli25
docs: Update timestamp.asciidoc (elastic#20395)
d98276f
@bmorelli25 bmorelli25 mentioned this pull request Oct 6, 2020
Merged
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/2.0-skip-…
36ed51a 
…ci-build-label-support

* upstream/master: (60 commits)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  Docker build resiliance with a retry (elastic#21587)
  Fix flaky FSWatch/FSScanner tests (elastic#21625)
  chore: add versions 7.1x (elastic#21670)
  [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599)
  Fix cyberark/corepas pipeline (elastic#21643)
  Add openstack ssl provider in add_cloud_metadata (elastic#21590)
  Add fips_enabled into all aws filesets (elastic#21626)
  [Filebeat S3] Change log.file.path to be nested object (elastic#21624)
  [CI] Change notification channel (elastic#21559)
  Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501)
  [E2E Tests] fix: set versions ony for PRs (elastic#21608)
  Fix badger build in 386 (elastic#21613)
  docs: Update timestamp.asciidoc (elastic#20395)
  Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457)
  [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498)
  [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585)
  [Ingest Manager] Use new form of fleet API paths (elastic#21478)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 8, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2…
b3b7cb1 
…012-2.0

* upstream/master: (110 commits)
  Skip publisher flaky tests (elastic#21657)
  backport: add 7.10 branch (elastic#21635)
  [CI: Packaging] fix: push ubi8 images too (elastic#21621)
  Docker build resiliance with a retry (elastic#21587)
  Fix flaky FSWatch/FSScanner tests (elastic#21625)
  chore: add versions 7.1x (elastic#21670)
  [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599)
  Fix cyberark/corepas pipeline (elastic#21643)
  Add openstack ssl provider in add_cloud_metadata (elastic#21590)
  Add fips_enabled into all aws filesets (elastic#21626)
  [Filebeat S3] Change log.file.path to be nested object (elastic#21624)
  [CI] Change notification channel (elastic#21559)
  Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501)
  [E2E Tests] fix: set versions ony for PRs (elastic#21608)
  Fix badger build in 386 (elastic#21613)
  docs: Update timestamp.asciidoc (elastic#20395)
  Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457)
  [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498)
  [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585)
  [Ingest Manager] Use new form of fleet API paths (elastic#21478)
  ...
bmorelli25 added a commit that referenced this pull request Oct 12, 2020
@bmorelli25 @Bernhard-Fluehmann
docs: Update timestamp.asciidoc (#20395) (#21604)
a61af91 
Co-authored-by: Bernhard Flühmann <bernhard.fluehmann@realstuff.ch>
bmorelli25 added a commit that referenced this pull request Oct 12, 2020
@bmorelli25 @Bernhard-Fluehmann
docs: Update timestamp.asciidoc (#20395) (#21605)
795cb94 
Co-authored-by: Bernhard Flühmann <bernhard.fluehmann@realstuff.ch>
bmorelli25 pushed a commit to bmorelli25/beats that referenced this pull request Oct 12, 2020
@Bernhard-Fluehmann @bmorelli25
docs: Update timestamp.asciidoc (elastic#20395)
1c894c0
@bmorelli25 bmorelli25 mentioned this pull request Oct 12, 2020
Merged
bmorelli25 added a commit that referenced this pull request Oct 13, 2020
@bmorelli25 @Bernhard-Fluehmann
docs: Update timestamp.asciidoc (#20395) (#21717)
974ded0 
Co-authored-by: Bernhard Flühmann <bernhard.fluehmann@realstuff.ch>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@bmorelli25 @Bernhard-Fluehmann
docs: Update timestamp.asciidoc (elastic#20395) (elastic#21604)
a4a5a3f 
Co-authored-by: Bernhard Flühmann <bernhard.fluehmann@realstuff.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dedemorton dedemorton dedemorton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Team:Services (Deprecated) Label for the former Integrations-Services team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Bernhard-Fluehmann @elasticmachine @bmorelli25 @dedemorton @andresrc