Add support for additional fields from V2 ALB logs#21540
Merged
kaiyan-sheng merged 4 commits intoelastic:masterfrom Oct 6, 2020
kaiyan-sheng:fix_elb_fb
Merged
Add support for additional fields from V2 ALB logs#21540kaiyan-sheng merged 4 commits intoelastic:masterfrom kaiyan-sheng:fix_elb_fb
kaiyan-sheng merged 4 commits intoelastic:masterfrom
kaiyan-sheng:fix_elb_fb
Conversation
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
sayden
reviewed
Oct 6, 2020
| "10.0.1.192:8010" | ||
| ], | ||
| "aws.elb.target_status_code": [ | ||
| "101" |
Contributor
There was a problem hiding this comment.
I guess there's a good reason to not use integers for the status code 😅
Contributor
Author
There was a problem hiding this comment.
Seems like in order to use the split processor later, the field has to be string with a separater. Splits a field into an array using a separator character. Only works on string fields. I will leave this question for now and if I find a better way to convert it into an integer, I will make a separate PR to fix it! Thanks!!
sayden
approved these changes
Oct 6, 2020
Contributor
sayden
left a comment
There was a problem hiding this comment.
Looks good but I left a question :)
6 tasks
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 6, 2020
* upstream/master: [CI] Setup git config globally (elastic#21562) docs: update generate_fields_docs.py (elastic#21359) Add support for additional fields from V2 ALB logs (elastic#21540) Move Prometheus query & remote_write to GA (elastic#21507) feat: add a new step to run the e2e tests for certain parts of Beats (elastic#21100) [Elastic Agent] Add elastic agent ID and version to events from filebeat and metricbeat. (elastic#21543) Release cloudfoundry input and processor as GA (elastic#21525) [Packetbeat] New SIP protocol (elastic#21221) [Filebeat][New Module] Add support for Microsoft MTP / 365 Defender (elastic#21446) [Beats][pytest] Asserting if filebeat logs include errors (elastic#20999) junipersrx-module initial release (elastic#20017) Add a persistent cache for cloudfoundry metadata based on badger (elastic#20775) Add missing changelog entry for cisco umbrella (elastic#21550) [Elastic Agent] Add upgrade CLI to initiate upgrade of Agent locally (elastic#21425) Enable filestream input (elastic#21533) Add filestream input reader (elastic#21481) [CI] fix 'no matches found within 10000' (elastic#21466) Fix billing.go aws.GetStartTimeEndTime (elastic#21531)
6 tasks
kaiyan-sheng
pushed a commit
that referenced
this pull request
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to add support for additional 4 fields from V2 ALB logs.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues