Skip to content

Move Prometheus query & remote_write to GA#21507

Merged
ChrsMark merged 4 commits intoelastic:masterfrom
ChrsMark:move_prom_to_ga
Oct 6, 2020
Merged

Move Prometheus query & remote_write to GA#21507
ChrsMark merged 4 commits intoelastic:masterfrom
ChrsMark:move_prom_to_ga

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Oct 5, 2020

This PR moves Prometheus query and Prometheus remote_write to GA.
Closes #21114

@ChrsMark
Move prometheus query & remote_write to GA
2758250 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added review needs_backport PR is waiting to be backported to other branches. [zube]: In Review Team:Platforms Label for the Integrations - Platforms team v7.10.0 labels Oct 5, 2020
@ChrsMark ChrsMark self-assigned this Oct 5, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 5, 2020

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 5, 2020
@ChrsMark
Add changelog entry
01f11d5 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested a review from exekias October 5, 2020 08:53
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 5, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21507 updated]

  • Start Time: 2020-10-05T10:25:57.258+0000

  • Duration: 85 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 2202
Skipped 488
Total 2690

@ChrsMark
Copy link
Copy Markdown
Member Author

ChrsMark commented Oct 5, 2020

@exekias what do u think about promoting these to GA with 7.10?

@exekias
Copy link
Copy Markdown
Contributor

exekias commented Oct 5, 2020

  • on this, I would also make use_types GA, as we plan that to be the default (only) experience in the Prometheus integration

cc @sorantis WDYT?

@exekias
Copy link
Copy Markdown
Contributor

exekias commented Oct 5, 2020

Some more detail about use_types. We plan to leverage elastic/elasticsearch#61939 once ready to remove the need for type suffixes (.value, .counter, .histogram). When ES is ready we will do a breaking change here.

We may want to wait for that before making use_types GA?

@sorantis
Copy link
Copy Markdown
Contributor

sorantis commented Oct 5, 2020

Some more detail about use_types. We plan to leverage elastic/elasticsearch#61939 once ready to remove the need for type suffixes (.value, .counter, .histogram). When ES is ready we will do a breaking change here.

We may want to wait for that before making use_types GA?

I think the idea was not to keep use_types flag anymore and make it transparent to the user. It seem that elastic/elasticsearch#61939 will help with that. If so will it mean that we'll remove the use_types flag from the package?

@exekias
Copy link
Copy Markdown
Contributor

exekias commented Oct 5, 2020

use_types won't be something users can configure in the package, still this is a feature present in the input for backwards compatibility. The package will set use_types: true in all cases

@ChrsMark
Copy link
Copy Markdown
Member Author

ChrsMark commented Oct 5, 2020

If we expect breaking changes after elastic/elasticsearch#61939 then I would agree on waiting before promoting use_types to GA. But would this be ok if we enabled it by default under the hood in the package?

@ChrsMark ChrsMark mentioned this pull request Oct 6, 2020
Merged
@ChrsMark ChrsMark merged commit 9d2f3b9 into elastic:master Oct 6, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Oct 6, 2020
@ChrsMark
Move Prometheus query & remote_write to GA (elastic#21507)
96c9676 
(cherry picked from commit 9d2f3b9)
@ChrsMark ChrsMark mentioned this pull request Oct 6, 2020
Merged
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Oct 6, 2020
v1v added a commit to v1v/beats that referenced this pull request Oct 6, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2016
fcd6db3 
* upstream/master:
  [CI] Setup git config globally (elastic#21562)
  docs: update generate_fields_docs.py (elastic#21359)
  Add support for additional fields from V2 ALB logs (elastic#21540)
  Move Prometheus query & remote_write to GA (elastic#21507)
  feat: add a new step to run the e2e tests for certain parts of Beats (elastic#21100)
  [Elastic Agent] Add elastic agent ID and version to events from filebeat and metricbeat. (elastic#21543)
  Release cloudfoundry input and processor as GA (elastic#21525)
  [Packetbeat] New SIP protocol (elastic#21221)
  [Filebeat][New Module] Add support for Microsoft MTP / 365 Defender (elastic#21446)
  [Beats][pytest] Asserting if filebeat logs include errors (elastic#20999)
  junipersrx-module initial release (elastic#20017)
  Add a persistent cache for cloudfoundry metadata based on badger (elastic#20775)
  Add missing changelog entry for cisco umbrella (elastic#21550)
  [Elastic Agent] Add upgrade CLI to initiate upgrade of Agent locally (elastic#21425)
  Enable filestream input (elastic#21533)
  Add filestream input reader (elastic#21481)
  [CI] fix 'no matches found within 10000' (elastic#21466)
  Fix billing.go aws.GetStartTimeEndTime (elastic#21531)
kaiyan-sheng pushed a commit that referenced this pull request Oct 6, 2020
@ChrsMark
Cherry-pick #21507 to 7.x: Move Prometheus query & remote_write to GA (…
ea4e077 
…#21574)

* Move Prometheus query & remote_write to GA (#21507)


(cherry picked from commit 9d2f3b9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@exekias exekias exekias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChrsMark ChrsMark

Labels

hacktoberfest-accepted review Team:Platforms Label for the Integrations - Platforms team v7.10.0 [zube]: In Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move query and remote_write metricsets of Prometheus to GA

5 participants

@ChrsMark @elasticmachine @exekias @sorantis @masci