Remove billing from the list of AWS light metricsets#21164
Merged
jsoriano merged 1 commit intoelastic:masterfrom Sep 18, 2020
Merged
Remove billing from the list of AWS light metricsets#21164jsoriano merged 1 commit intoelastic:masterfrom
jsoriano merged 1 commit intoelastic:masterfrom
Conversation
At least on tests, loading any metricset from the AWS module is trying to load the billing metricset as light metricset, what fails. This shouldn't happen, but I am removing billing from the list by now so tests can be executed.
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
v1v
approved these changes
Sep 18, 2020
kaiyan-sheng
approved these changes
Sep 18, 2020
Contributor
kaiyan-sheng
left a comment
There was a problem hiding this comment.
Thank you for fixing it!! Sorry I missed it when I changed billing metricset recently.
Member
Author
No prob, this list of light metricsets has proven to be problematic! |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Sep 18, 2020
On tests, loading any metricset from the AWS module is trying to load the billing metricset as light metricset, what fails. This shouldn't happen after elastic#15011, but it is probably happening because on tests, not all metricsets are registered. billing metricset was refactored to a native implementation recently, in elastic#20527. By now, remove billing from the list so tests can be executed. (cherry picked from commit 43f9bbc)
jsoriano
added a commit
that referenced
this pull request
Sep 18, 2020
On tests, loading any metricset from the AWS module is trying to load the billing metricset as light metricset, what fails. This shouldn't happen after #15011, but it is probably happening because on tests, not all metricsets are registered. billing metricset was refactored to a native implementation recently, in #20527. By now, remove billing from the list so tests can be executed. (cherry picked from commit 43f9bbc)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 18, 2020
…ne-2.0 * upstream/master: Remove billing from the list of AWS light metricsets (elastic#21164)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On tests, loading any metricset from the AWS module is trying
to load the billing metricset as light metricset, what fails. This
shouldn't happen after #15011, but it is probably happening
because on tests, not all metricsets are registered.
billingmetricset was refactored to a native implementationrecently, in #20527.
By now I am removing billing from the list so tests can be executed.
Integration tests fail with errors like this one:
Thanks @v1v for reporting!