Skip to content

Cherry-pick #21164 to 7.x: Remove billing from the list of AWS light metricsets#21170

Merged
jsoriano merged 1 commit intoelastic:7.xfrom
jsoriano:backport_21164_7.x
Sep 18, 2020
Merged

Cherry-pick #21164 to 7.x: Remove billing from the list of AWS light metricsets#21170
jsoriano merged 1 commit intoelastic:7.xfrom
jsoriano:backport_21164_7.x

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Sep 18, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21164 to 7.x branch. Original message:

On tests, loading any metricset from the AWS module is trying
to load the billing metricset as light metricset, what fails. This
shouldn't happen after #15011, but it is probably happening
because on tests, not all metricsets are registered.

billing metricset was refactored to a native implementation
recently, in #20527.

By now I am removing billing from the list so tests can be executed.

Integration tests fail with errors like this one:

go test -tags=integration,aws ./x-pack/metricbeat/module/aws/sns/
--- FAIL: TestData (0.00s)
    modules.go:111: failed to create new MetricSet 1 error: failed to obtain registration for non-registered metricset 'aws/sns': loading module 'aws': loading metric sets for light module 'aws': loading light metricset 'billing': loading metricset manifest from '../../../module/aws/billing/manifest.yml': open ../../../module/aws/billing/manifest.yml: no such file or directory
FAIL
FAIL	github.com/elastic/beats/v7/x-pack/metricbeat/module/aws/sns	0.013s
FAIL

Thanks @v1v for reporting!

@jsoriano
Remove billing from the list of AWS light metricsets (elastic#21164)
ec684a0 
On tests, loading any metricset from the AWS module is trying
to load the billing metricset as light metricset, what fails. This
shouldn't happen after elastic#15011, but it is probably happening
because on tests, not all metricsets are registered.

billing metricset was refactored to a native implementation
recently, in elastic#20527.

By now, remove billing from the list so tests can be executed.

(cherry picked from commit 43f9bbc)
@jsoriano jsoriano added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Sep 18, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 18, 2020

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 18, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 18, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21170 opened]

  • Start Time: 2020-09-18T12:46:19.515+0000

  • Duration: 51 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 845
Skipped 72
Total 917

@jsoriano jsoriano merged commit 91a312f into elastic:7.x Sep 18, 2020
@jsoriano jsoriano deleted the backport_21164_7.x branch September 18, 2020 14:04
@zube zube bot removed the [zube]: Done label Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsoriano @elasticmachine @kaiyan-sheng