Make compute_vm light metricset and add update cloud instance id#20889
Make compute_vm light metricset and add update cloud instance id#20889narph merged 27 commits intoelastic:masterfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
| } | ||
| } | ||
| "id": "d5d9444a-1964-4d23-9c62-5463ecb16fe0", | ||
| "name": "obslinux" |
There was a problem hiding this comment.
Uh oh, we are missing the rest of the host fields.
There was a problem hiding this comment.
@kaiyan-sheng , the values used to map those host fields are not retrieved in this event, most likely the next one containing those values will. as you can see only percentage_cpu is contained in the metrics.
| } | ||
|
|
||
| // getResourceNameFormId maps resource group from resource ID | ||
| func getResourceNameFromId(path string) string { |
There was a problem hiding this comment.
Maybe these functions could be moved to a utils.go file since look too generic?
| return false | ||
| } | ||
|
|
||
| func containsResource(resId string, resources []Resource) bool { |
There was a problem hiding this comment.
It this actually client's utils or is could be re-organised to a generic utils.go for the whole azure module?
There was a problem hiding this comment.
it is clients_utils , would like to keep it that way for the moment as it might get too muddy if we add more functionality, once a function is reused at other levels as service etc then it needs rethinking.
ChrsMark
left a comment
There was a problem hiding this comment.
Left some suggestions/questions mostly about code organization. Not being so familiar with this stuff but I don't see anything blocking this.
…stic#20889) * mofidy doc * rewrite * fix * temp * tests * work * changelog * fit tests * update dashboards (cherry picked from commit f8c2477)
…stic#20889) * mofidy doc * rewrite * fix * temp * tests * work * changelog * fit tests * update dashboards
What does this PR do?
compute_vmto light metricsetcloud.instance.idandcloud.instance.namefields only forcompute_vmonlyaazure.resource.nameandazure.resource.idback to all metricsetsWhy is it important?
compute_vmto light metricsetChecklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
cloud.instance.idto the vm id in the compute_vm metricset #20754