Skip to content

Cherry-pick #20889 to 7.x: Make compute_vm light metricset and add update cloud instance id#21015

Merged
narph merged 2 commits intoelastic:7.xfrom
narph:backport_20889_7.x
Sep 14, 2020
Merged

Cherry-pick #20889 to 7.x: Make compute_vm light metricset and add update cloud instance id#21015
narph merged 2 commits intoelastic:7.xfrom
narph:backport_20889_7.x

Conversation

@narph
Copy link
Copy Markdown
Contributor

@narph narph commented Sep 8, 2020

Cherry-pick of PR #20889 to 7.x branch. Original message:

What does this PR do?

  • rewrites the compute_vm to light metricset
  • maps the cloud.instance.id and cloud.instance.name fields only for compute_vm onlya
  • add azure.resource.name and azure.resource.id back to all metricsets

Why is it important?

  • rewrites the compute_vm to light metricset
  • maps the cloud.instance.id field

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@narph
Make compute_vm light metricset and add update cloud instance id (ela…
4c2db11 
…stic#20889)

* mofidy doc

* rewrite

* fix

* temp

* tests

* work

* changelog

* fit tests

* update dashboards

(cherry picked from commit f8c2477)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2020
@narph narph self-assigned this Sep 8, 2020
@narph narph added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Sep 8, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 8, 2020

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 8, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21015 updated]

  • Start Time: 2020-09-08T10:19:52.123+0000

  • Duration: 70 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 3591
Skipped 798
Total 4389

ChrsMark
ChrsMark approved these changes Sep 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I guess that the extra lines I see in diff count (comparing to the original PR) are intentional additions.

@narph narph merged commit 6ae258e into elastic:7.x Sep 14, 2020
@narph narph deleted the backport_20889_7.x branch September 14, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels

backport Team:Platforms Label for the Integrations - Platforms team [zube]: In Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@narph @elasticmachine @ChrsMark @andresrc