[Packetbeat] HTTP: Improve support for 100-continue #15830 by OhBonsai · Pull Request #19349 · elastic/beats

OhBonsai · 2020-06-24T05:07:20Z

What does this PR do?

Improve support for 100-continue #15830

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

nosetests ./tests/system/test_0070_http_100_continue.py

Related issues

#15830

elasticmachine · 2020-06-24T05:07:22Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2020-06-24T05:07:22Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

cla-checker-service · 2020-06-24T05:07:23Z

💚 CLA has been signed

elasticmachine · 2020-06-24T05:13:18Z

💚 Build Succeeded

Expand to view the summary

Build stats

Build Cause: [marc-gr commented: jenkins run tests]
Start Time: 2020-07-27T07:54:23.361+0000
Duration: 44 min 6 sec

Test stats 🧪

Test	Results
Failed	0
Passed	1061
Skipped	12
Total	1073

elasticmachine · 2020-06-24T07:30:53Z

Pinging @elastic/siem (Team:SIEM)

marc-gr · 2020-07-15T09:11:40Z

Thanks for your first PR @OhBonsai !

Please we need you to sign our CLA, you can follow instruction for this here.

marc-gr · 2020-07-15T09:11:53Z

jenkins run tests

OhBonsai · 2020-07-16T12:22:58Z

@marc-gr
I have signed many times.. But it's seems not working... Anything wrong?

marc-gr · 2020-07-16T12:31:28Z

@marc-gr
I have signed many times.. But it's seems not working... Anything wrong?

It seems to be OK now, maybe the email used to commit was different than the one you used to sign before. Thanks!

marc-gr · 2020-07-16T12:33:17Z

jenkins run tests

marc-gr · 2020-07-17T08:10:37Z

jenkins run tests

marc-gr · 2020-07-17T08:13:45Z

It seems it has linting issues:

+++ b/packetbeat/tests/system/test_0070_http_100_continue.py
@@ -30,5 +30,3 @@ class Test(BaseTest):
         assert "response" in o["http"]
 
         assert not "error" in o
-
-
Error: some files are not up-to-date. Run 'mage fmt update' then review and commit the changes. Modified: [packetbeat/tests/system/test_0070_http_100_continue.py]

You can fix this by running mage fmt update in packetbeat folder and commiting its output. Also an entry in the CHANGELOG.next.asciidoc needs to be added. Let us know if you have any issues or want us to take over from this point, whatever works best for you :)

Thanks!

OhBonsai · 2020-07-17T09:11:56Z

@marc-gr To Be Reviewed

marc-gr · 2020-07-17T09:17:14Z

jenkins run tests

marc-gr · 2020-07-21T08:02:23Z

jenkins run tests

marc-gr · 2020-07-21T08:03:03Z

@OhBonsai I merged master since tests were red and your branch was quite behind

OhBonsai · 2020-07-21T10:59:17Z

@marc-gr Thanks... So there is anything else I need to do ?

marc-gr · 2020-07-22T14:16:29Z

@marc-gr Thanks... So there is anything else I need to do ?

I would like @adriansr to have a look since he is more familiar with packetbeat 👍

packetbeat/protos/http/http.go

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>

adriansr · 2020-07-27T07:20:20Z

jenkins, test this

marc-gr · 2020-07-27T07:53:38Z

jenkins run tests

…astic#19349) * refactor(packet beat): Improve support for 100-continue * test(packetbeat): 100-continue only generate one event without error * test(packetbeat): 100-continue only generate one event without error * Update packetbeat/protos/http/http.go Co-authored-by: Adrian Serrano <adrisr83@gmail.com> * delete unused string * Fix format issue Co-authored-by: Marc Guasch <marc.guasch@elastic.co> Co-authored-by: Adrian Serrano <adrisr83@gmail.com> (cherry picked from commit 41bc8c6)

…ne-2.0 * upstream/master: (41 commits) adding possibility to override content-type checks, it was breaking certain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232) fix: use a fixed worker type for tests (elastic#20130) [Ingest Manager] Prepare packaging for endpoint and asc files (elastic#20186) [Packetbeat] HTTP: Improve support for 100-continue elastic#15830 (elastic#19349) Increase index.max_docvalue_fields_search to 200 (elastic#20218) [Ingest Manager] Prevent closing closed reader (elastic#20214) [Metricbeat] Use MySQL Host Parser in Query metricset (elastic#20191) Testing: Ignore timestamp from cylance/protect dataset (elastic#20211) [Filebeat] Ignore cylance.protect timestamps while testing (elastic#20207) [CI] remove codecov step (elastic#20102) [docs] Indicate that SYSTEM user is required on Windows to use Endpoint (elastic#20172) Remove f5/firepass rsa2elk fileset (elastic#20160) [Elastic Agent] Improve GRPC stop to be more relaxed. (elastic#20118) Fix fileset field prefixing (elastic#20170) Fix terminating pod autodiscover issue (elastic#20084) Call host parser only once when building light metricsets (elastic#20149) [CI] fix null string with contains (elastic#20182) [Ingest Manager] Fix failing unit tests on windows (elastic#20127) [Filebeat] Update crowdstrike module (elastic#20138) [docs] Add x-pack role to relevant metricsets (elastic#20167) ...

…20234) * refactor(packet beat): Improve support for 100-continue * test(packetbeat): 100-continue only generate one event without error * test(packetbeat): 100-continue only generate one event without error * Update packetbeat/protos/http/http.go Co-authored-by: Adrian Serrano <adrisr83@gmail.com> * delete unused string * Fix format issue Co-authored-by: Marc Guasch <marc.guasch@elastic.co> Co-authored-by: Adrian Serrano <adrisr83@gmail.com> (cherry picked from commit 41bc8c6) Co-authored-by: Bonsai <LetBonsaiBe@gmail.com>

…astic#19349) * refactor(packet beat): Improve support for 100-continue * test(packetbeat): 100-continue only generate one event without error * test(packetbeat): 100-continue only generate one event without error * Update packetbeat/protos/http/http.go Co-authored-by: Adrian Serrano <adrisr83@gmail.com> * delete unused string * Fix format issue Co-authored-by: Marc Guasch <marc.guasch@elastic.co> Co-authored-by: Adrian Serrano <adrisr83@gmail.com>

OhBonsai requested a review from a team as a code owner June 24, 2020 05:07

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2020

andresrc added the Team:SIEM label Jun 24, 2020

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2020

refactor(packet beat): Improve support for 100-continue

bbc1e8f

OhBonsai added 2 commits July 17, 2020 16:49

test(packetbeat): 100-continue only generate one event without error

e2482e0

test(packetbeat): 100-continue only generate one event without error

178538d

Merge remote-tracking branch 'upstream/master'

504e185

marc-gr requested a review from adriansr July 22, 2020 14:15

adriansr self-assigned this Jul 22, 2020

adriansr suggested changes Jul 22, 2020

View reviewed changes

packetbeat/protos/http/http.go Outdated Show resolved Hide resolved

Update packetbeat/protos/http/http.go

7252e4c

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>

OhBonsai and others added 2 commits July 23, 2020 11:35

delete unused string

9a9b921

Fix format issue

651f9f7

adriansr approved these changes Jul 27, 2020

View reviewed changes

adriansr added enhancement Packetbeat labels Jul 27, 2020

marc-gr merged commit 41bc8c6 into elastic:master Jul 27, 2020

marc-gr mentioned this pull request Jul 27, 2020

Cherry-pick #19349 to 7.x: [Packetbeat] HTTP: Improve support for 100-continue #15830 #20234

Merged

3 tasks

marc-gr added the v7.10.0 label Jul 27, 2020

marc-gr mentioned this pull request Oct 22, 2021

[Packetbeat] HTTP: Improve support for 100-continue #15830

Closed

Conversation

OhBonsai commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist

How to test this PR locally

Related issues

Uh oh!

elasticmachine commented Jun 24, 2020

Uh oh!

elasticmachine commented Jun 24, 2020

Uh oh!

cla-checker-service bot commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jun 24, 2020 • edited by jenkins-beats-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

Uh oh!

elasticmachine commented Jun 24, 2020

Uh oh!

marc-gr commented Jul 15, 2020

Uh oh!

marc-gr commented Jul 15, 2020

Uh oh!

OhBonsai commented Jul 16, 2020

Uh oh!

marc-gr commented Jul 16, 2020

Uh oh!

marc-gr commented Jul 16, 2020

Uh oh!

marc-gr commented Jul 17, 2020

Uh oh!

marc-gr commented Jul 17, 2020

Uh oh!

OhBonsai commented Jul 17, 2020

Uh oh!

marc-gr commented Jul 17, 2020

Uh oh!

marc-gr commented Jul 21, 2020

Uh oh!

marc-gr commented Jul 21, 2020

Uh oh!

OhBonsai commented Jul 21, 2020

Uh oh!

marc-gr commented Jul 22, 2020

Uh oh!

Uh oh!

adriansr commented Jul 27, 2020

Uh oh!

marc-gr commented Jul 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

OhBonsai commented Jun 24, 2020 •

edited

Loading

cla-checker-service bot commented Jun 24, 2020 •

edited

Loading

elasticmachine commented Jun 24, 2020 •

edited by jenkins-beats-ci bot

Loading