[Metricbeat] Update Couchbase module to 6.5 version#19055
Merged
sayden merged 12 commits intoelastic:masterfrom Jun 26, 2020
Merged
[Metricbeat] Update Couchbase module to 6.5 version#19055sayden merged 12 commits intoelastic:masterfrom
sayden merged 12 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
Contributor
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
jsoriano
reviewed
Jun 17, 2020
Member
jsoriano
left a comment
There was a problem hiding this comment.
Change looks good, added some suggestions about compatibility notes, changelog and tests.
jsoriano
reviewed
Jun 17, 2020
Member
jsoriano
left a comment
There was a problem hiding this comment.
LGTM, but failures in tests seem to be related.
91d5cb6 to
4d66925
Compare
jsoriano
approved these changes
Jun 26, 2020
sayden
added a commit
to sayden/beats
that referenced
this pull request
Jun 26, 2020
(cherry picked from commit c7f9937)
6 tasks
sayden
added a commit
to sayden/beats
that referenced
this pull request
Jun 26, 2020
(cherry picked from commit c7f9937)
6 tasks
sayden
added a commit
to sayden/beats
that referenced
this pull request
Jun 26, 2020
(cherry picked from commit c7f9937) # Conflicts: # metricbeat/docs/fields.asciidoc # metricbeat/module/couchbase/_meta/Dockerfile # metricbeat/module/couchbase/_meta/docs.asciidoc # metricbeat/module/couchbase/docker-compose.yml # metricbeat/module/couchbase/fields.go # metricbeat/module/couchbase/test_couchbase.py
6 tasks
sayden
added a commit
that referenced
this pull request
Jun 26, 2020
sayden
added a commit
that referenced
this pull request
Jun 26, 2020
sayden
added a commit
that referenced
this pull request
Jun 26, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the number format of some fields that seems to be returned in floating point while we expect them like integers.
It seems that some of the values returned by Couchbase are in floating point numbers. In fact, all the data is returned in JSON format so every single number might be a floating point number.
Checklist
[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Just execute the module normally. Unfortunately, the bug can't be reproduce easily (or at all)
Related issues
Fixes: #18949
Fixes: #18595