Skip to content

Cherry-pick #19055 to 6.8: [Metricbeat] Update Couchbase module to 6.5 version#19462

Merged
sayden merged 4 commits intoelastic:6.8from
sayden:backport_19055_6.8
Jun 26, 2020
Merged

Cherry-pick #19055 to 6.8: [Metricbeat] Update Couchbase module to 6.5 version#19462
sayden merged 4 commits intoelastic:6.8from
sayden:backport_19055_6.8

Conversation

@sayden
Copy link
Copy Markdown
Contributor

@sayden sayden commented Jun 26, 2020

Cherry-pick of PR #19055 to 6.8 branch. Original message:

What does this PR do?

Changes the number format of some fields that seems to be returned in floating point while we expect them like integers.

It seems that some of the values returned by Couchbase are in floating point numbers. In fact, all the data is returned in JSON format so every single number might be a floating point number.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Check that dashboards still works in v4.5, v5 and v6.5

How to test this PR locally

Just execute the module normally. Unfortunately, the bug can't be reproduce easily (or at all)

Related issues

Fixes: #18949
Fixes: #18595

(cherry picked from commit c7f9937)

# Conflicts:
#	metricbeat/docs/fields.asciidoc
#	metricbeat/module/couchbase/_meta/Dockerfile
#	metricbeat/module/couchbase/_meta/docs.asciidoc
#	metricbeat/module/couchbase/docker-compose.yml
#	metricbeat/module/couchbase/fields.go
#	metricbeat/module/couchbase/test_couchbase.py
@sayden sayden added backport [zube]: In Review Team:Services (Deprecated) Label for the former Integrations-Services team labels Jun 26, 2020
@sayden sayden self-assigned this Jun 26, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 26, 2020
@jsoriano jsoriano self-requested a review June 26, 2020 16:07
@jsoriano
Copy link
Copy Markdown
Member

jenkins, test this again please

@jsoriano
Copy link
Copy Markdown
Member

Failures in travis and jenkins are not new, tests pass locally.

@sayden sayden merged commit 08e37b5 into elastic:6.8 Jun 26, 2020
@zube zube bot removed the [zube]: Done label Oct 13, 2020
@sayden sayden deleted the backport_19055_6.8 branch October 29, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Services (Deprecated) Label for the former Integrations-Services team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants