Cherry-pick #18020 to 7.x: Fix generated metricbeat so create-metricset works.#18063
Merged
blakerouse merged 1 commit intoelastic:7.xfrom Apr 28, 2020
Merged
Cherry-pick #18020 to 7.x: Fix generated metricbeat so create-metricset works.#18063blakerouse merged 1 commit intoelastic:7.xfrom
blakerouse merged 1 commit intoelastic:7.xfrom
Conversation
* Fix generated metricbeat so create-metricset works. * Fix mage target add target to x-pack/metricbeat. (cherry picked from commit 77f0d20)
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
Contributor
Author
|
Part 1 of backport, part 2 still landing in master, will come into 7.x as well. |
kaiyan-sheng
approved these changes
Apr 28, 2020
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18020 to 7.x branch. Original message:
What does this PR do?
Fixes the
make -C generator/_templates/metricbeat testso thatmake create-metricsetworks inside of the generated custom metricbeat.Why is it important?
Both so
create-metricsetworks on the generated beat and so the CI passes.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.