Fix generated metricbeat so create-metricset works.#18020
Fix generated metricbeat so create-metricset works.#18020blakerouse merged 2 commits intoelastic:masterfrom
Conversation
| // Required ENV variables: | ||
| // * MODULE: Name of the module | ||
| // * METRICSET: Name of the metricset | ||
| func CreateMetricset() error { |
There was a problem hiding this comment.
For consistency with other targets' functions, how about taking a context.Context here as well?
There was a problem hiding this comment.
Being that it's not using it, I removed it. Should we have it there even if its not being used?
There was a problem hiding this comment.
Yeah, I could go either way over here. I see that other targets have it and it's not being used in them as well.
Personally, I'd prefer to leave it out if it's not being used (so 👍 to what you've done here) but perhaps we should also do that everywhere else in a follow up PR.
ycombinator
left a comment
There was a problem hiding this comment.
Left a nit, otherwise LGTM. Thanks for fixing! <3
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
|
@blakerouse CI failure looks related. |
|
Yeah its related, but do not know why its saying it is not present. From the commit you can see that it is present. @kvch Any ideas why that would be the case? |
|
@blakerouse I wonder if you need to split this PR up into two. First, one introducing the |
…unbld * upstream/master: ci: comment PRs with the build status (elastic#17971) Add domain state metricset to kvm module (elastic#17673) [Agent] Allow CLI paths override (elastic#17781) Fix generated metricbeat so create-metricset works. (elastic#18020) LIBBEAT: Enhancement replace_string processor for replacing strings values of fields. (elastic#17342) Update stale references to _xpack to refer to _license instead (elastic#18030) Review dependency patterns collection in Jenkins (elastic#18004)
* Fix generated metricbeat so create-metricset works. * Fix mage target add target to x-pack/metricbeat. (cherry picked from commit 77f0d20)
What does this PR do?
Fixes the
make -C generator/_templates/metricbeat testso thatmake create-metricsetworks inside of the generated custom metricbeat.Why is it important?
Both so
create-metricsetworks on the generated beat and so the CI passes.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.