[Metricbeat] allow partial region and zone in googlecloud module config#17913
Merged
kaiyan-sheng merged 7 commits intoelastic:masterfrom Apr 27, 2020
kaiyan-sheng:regions_gcp
Merged
[Metricbeat] allow partial region and zone in googlecloud module config#17913kaiyan-sheng merged 7 commits intoelastic:masterfrom kaiyan-sheng:regions_gcp
kaiyan-sheng merged 7 commits intoelastic:masterfrom
kaiyan-sheng:regions_gcp
Conversation
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
blakerouse
reviewed
Apr 23, 2020
Contributor
blakerouse
left a comment
There was a problem hiding this comment.
Would it be better to only enable this behavior with a wildcard?
us-* instead of us-
Contributor
Author
|
Good point! I will add that! Thanks @blakerouse !! |
Contributor
Author
|
@blakerouse I added |
blakerouse
approved these changes
Apr 27, 2020
Contributor
blakerouse
left a comment
There was a problem hiding this comment.
I see that you allowed with and without the * that is nice. Looks like mage update might need to be called before merging. Otherwise looks good.
Contributor
Author
|
Yeah, gcp user who uses their API a lot will probably put region/zone without |
6 tasks
This was referenced May 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to enable partial region and partial zone in googlecloud module config. User can choose to use wildcard
*or not. For example:This config will enable data collection from all regions start with
us-west, which includesus-west1,us-west2,us-west3andus-west4.Similarly this config will enable data collection from all regions start with
us-, which includes all regions starts withus-west,us-eastandus-central.Why is it important?
This will allow users to not copy paste region/zone names when they want to monitor several regions/zones. If user wants to monitor all regions in both US and Europe, they still need to copy paste but that's very minimum. For example:
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
There are two parts need to be tested. One for regions and another for zones.
Enable googlecloud with this config and you should see metrics collection from all regions start with
us-.Enable googlecloud with this config and you should see metrics collection from all zones start with
europe-west3-, which includeseurope-west3-a,europe-west3-bandeurope-west3-c.Related issues