Cherry-pick #17913 to 7.x: [Metricbeat] allow partial region and zone in googlecloud module config#18015
Cherry-pick #17913 to 7.x: [Metricbeat] allow partial region and zone in googlecloud module config#18015kaiyan-sheng merged 2 commits intoelastic:7.xfrom kaiyan-sheng:backport_17913_7.x
Conversation
ycombinator
left a comment
There was a problem hiding this comment.
LGTM.
Looks like there are some additional changes in metricbeat/docs/modules/googlecloud.asciidoc but they look like cleanup. Just wondering if you intend to make these same changes in master too — in that case, it might be better to remove them from this PR and backport them on their own?
|
@ycombinator I'm wondering the same thing hmmm I tried to run |
|
I think you're running the right command. I'm guessing there is some difference in the doc toolchains between |
|
This pull request doesn't have a |
Cherry-pick of PR #17913 to 7.x branch. Original message:
What does this PR do?
This PR is to enable partial region and partial zone in googlecloud module config. User can choose to use wildcard
*or not. For example:This config will enable data collection from all regions start with
us-west, which includesus-west1,us-west2,us-west3andus-west4.Similarly this config will enable data collection from all regions start with
us-, which includes all regions starts withus-west,us-eastandus-central.Why is it important?
This will allow users to not copy paste region/zone names when they want to monitor several regions/zones. If user wants to monitor all regions in both US and Europe, they still need to copy paste but that's very minimum. For example:
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
There are two parts need to be tested. One for regions and another for zones.
Enable googlecloud with this config and you should see metrics collection from all regions start with
us-.Enable googlecloud with this config and you should see metrics collection from all zones start with
europe-west3-, which includeseurope-west3-a,europe-west3-bandeurope-west3-c.Related issues