[Agent] Handle abs paths on windows correctly#17461
Merged
ph merged 5 commits intoelastic:masterfrom Apr 6, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ingest-management (Project:fleet) |
6 tasks
ph
approved these changes
Apr 3, 2020
Contributor
ph
left a comment
There was a problem hiding this comment.
LGTM, lets get the jenkins changes in before so we can test it on CI.
Contributor
|
I've looked at our lint job and this look like some instability from Jenkins: |
Contributor
|
backported in #17599 |
ph
added a commit
that referenced
this pull request
Apr 14, 2020
) * [Agent] Rename agent to elastic-agent (#17391) [Agent] Rename agent to elastic-agent (#17391) (cherry picked from commit 66609a3) * Add Elastic Agent in the Jenkinsfile (#17445) * Add Elastic Agent in the Jenkinsfile With the recent moves to Jenkins pipeline the Elastic Agent project was not currently tested. * Add Elastic Agent in the Jenkinsfile (#17445) * Add Elastic Agent in the Jenkinsfile With the recent moves to Jenkins pipeline the Elastic Agent project was not currently tested. * [Agent] Fix merge of config (#17399) [Agent] Fix merge of config #17399 * [Agent] Handle abs paths on windows correctly (#17461) * handle windows correctly * Missing commits from the initial merges of the agent -> master Co-authored-by: Michal Pristas <michal.pristas@gmail.com> Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If absolute path in unix format is used in config, IsAbs on windows returns false. so we first transform it to windows path format and then handle the logic as usual.
For transformation volume of root directory passed is used, it is usually a directory where installed beat is located.
Why is it important?
Supporting windows
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Fixes #17449